From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org, Ian Campbell <Ian.Campbell@citrix.com>,
george.dunlap@citrix.com
Subject: Re: [PATCH] xl: suppress suspend/resume functions on platforms which do not support it.
Date: Fri, 14 Feb 2014 13:42:52 +0800 [thread overview]
Message-ID: <52FDACDC.2010607@cn.fujitsu.com> (raw)
In-Reply-To: <21243.35619.819765.162321@mariner.uk.xensource.com>
On 02/12/2014 10:54 PM, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH] xl: suppress suspend/resume functions on platforms which do not support it."):
>> On Wed, 2014-02-12 at 14:27 +0000, Ian Campbell wrote:
>>> ARM does not (currently) support migration, so stop offering tasty looking
>>> treats like "xl migrate".
>
>>> Other than the additions of the #define/#ifdef there is a tiny bit of code
>>> motion ("dump-core" in the command list and core_dump_domain in the
>>> implementations) which serves to put ifdeffable bits next to each other.
>
> I'm not a huge fan of #ifdef but this is tolerable, I think.
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Also
Acked-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Thanks,
Lai
>
> I think this should go into 4.4. It is essential that we start
> advertising lack-of-resume in 4.4 as otherwise in 4.5 we'll have to
> invent a new HAVE_HAVE_NO_SUSPEND_RESUME which tells you whether the
> lack of HAVE_NO_SUSPEND_RESUME means that you can definitely
> suspend/resume.
>
> Ian.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
next prev parent reply other threads:[~2014-02-14 5:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 14:27 [PATCH] xl: suppress suspend/resume functions on platforms which do not support it Ian Campbell
2014-02-12 14:32 ` Ian Campbell
2014-02-12 14:54 ` Ian Jackson
2014-02-13 9:19 ` Ian Campbell
2014-02-14 5:42 ` Lai Jiangshan [this message]
2014-02-18 9:57 ` Ian Campbell
2014-02-12 16:48 ` George Dunlap
2014-02-12 14:32 ` [PATCH OSSTEST] Do not attempt migration tests if the platform doesn't " Ian Campbell
2014-02-12 14:58 ` Ian Jackson
2014-02-12 15:21 ` [PATCH] xl: suppress suspend/resume functions on platforms which do not " Olaf Hering
2014-02-12 15:57 ` Ian Campbell
2014-02-12 16:49 ` George Dunlap
2014-02-12 16:54 ` Ian Campbell
2014-02-12 17:00 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FDACDC.2010607@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=george.dunlap@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.