Re: [PATCH 03/16] scsi_dh_alua: Pass buffer as function argument

[Hannes Reinecke <hare@suse.de>]

On 02/14/2014 12:22 PM, Bart Van Assche wrote:
> On 01/31/14 10:29, Hannes Reinecke wrote:
>> -	rq->cmd[6] = (h->bufflen >> 24) & 0xff;
>> -	rq->cmd[7] = (h->bufflen >> 16) & 0xff;
>> -	rq->cmd[8] = (h->bufflen >>  8) & 0xff;
>> -	rq->cmd[9] = h->bufflen & 0xff;
>> +	rq->cmd[6] = (bufflen >> 24) & 0xff;
>> +	rq->cmd[7] = (bufflen >> 16) & 0xff;
>> +	rq->cmd[8] = (bufflen >>  8) & 0xff;
>> +	rq->cmd[9] = bufflen & 0xff;
> 
> Since you are changing this code, please use put_unaligned_be32() for
> storing bufflen in the CDB.
> 
Ok. Will be fixing it up in the next round.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html