From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Date: Fri, 14 Feb 2014 12:31:24 +0000 Subject: Re: [PATCH RFC 2/3] fbdev: move fbdev core files to separate directory Message-Id: <52FE0C9C.6090905@ti.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="H0fDMKj3Um9qoHsuRgn0hO7GjHmd1oDLF" List-Id: References: <1392376711-11290-1-git-send-email-tomi.valkeinen@ti.com> <1392376711-11290-2-git-send-email-tomi.valkeinen@ti.com> In-Reply-To: To: Geert Uytterhoeven Cc: Linux Fbdev development list , DRI Development , "linux-kernel@vger.kernel.org" , Laurent Pinchart , Jean-Christophe Plagniol-Villard , David Airlie --H0fDMKj3Um9qoHsuRgn0hO7GjHmd1oDLF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 14/02/14 14:27, Geert Uytterhoeven wrote: > Hi Tomi, >=20 > Thanks for doing this! >=20 > Acked-by: Geert Uytterhoeven >=20 > On Fri, Feb 14, 2014 at 12:18 PM, Tomi Valkeinen wrote: >> --- a/drivers/video/fbdev/fbmon.c >> +++ b/drivers/video/fbdev/core/fbmon.c >> @@ -37,7 +37,7 @@ >> #include >> #include >> /* >> * EDID parserpci-bridge.h> >> #endif >> -#include "edid.h" >> +#include "../edid.h" >=20 > This looks a bit asymmetrical ... >=20 >> --- a/drivers/video/fbdev/wmt_ge_rops.c >> +++ b/drivers/video/fbdev/wmt_ge_rops.c >> @@ -18,7 +18,7 @@ >> #include >> #include >> #include >> -#include "fb_draw.h" >> +#include "core/fb_draw.h" >=20 > ... to this. >=20 > Perhaps (the content of) edid.h belongs in include/video/edid.h? Yes, I thought the same, but I didn't want to start messing around too much in this series. I also noticed some odd Kconfig options (for example, HAVE_FB_ATMEL, SH_MIPI_DSI, SH_LCD_MIPI_DSI at the beginning of drivers/video/Kconfig), which I almost started cleaning up, but decided to just concentrate on the main reorganization. Tomi --H0fDMKj3Um9qoHsuRgn0hO7GjHmd1oDLF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS/gyjAAoJEPo9qoy8lh715ugQAIUwVqQC15qPyjBynI7AsFEi JerkdL7p+vQvPquO/p0T/aBqjalZszWBxDw+VdC5ilo4ekqA8TIiGrmSYmKpSQuB IG0dnOo3wg3bZpZrTUPp8gKqN60olta3HmT89nUGuCdHJxtlC8BOcN+7NV0/Lix8 9Pw/OCug4pufvGxeCnJoGGL4fle+pKyxa5YsEdHdz0qic86SKs/tGy5+s/0xzsyA jr0U74LmNQMEuJzEd4/krCacRDFmoUj+29uWOaYhxIAshlqkIo0Ou2JY7U7V8ozP A06HE6nBLHAd3hLsjZYEG68mOuYmkBKEvJipaSzm9Q8+YU6dgjxyAaZtjl8KLdPc I4dBtsYKsURe8D7AJ0irK9M2VU2rCgc1UzMF0StwuNQDou79jTsPn7gg3m/BCQN3 Ig7xUXcoCYxe3rSBJEYWyzzVqe8rXuhMEJ8Bx7xCJabWSaYPPhgRP4jAgVe8TcvS rFI9Fz1LQO5cJA8A/eR4PG5wXZz9T6jEiukqkSglBe3EL8OkU7DqJvgCw+sh7dm5 ta8aMWQ9EohM0sgIXCSQxCwVdM1vri5mAyiDZ/sE0qVP31Zphrq8pgWAa5kkpxP9 Pc4zsq5BjrsdKn7as2c3JPK75u0lL8ZFrBhsuF3PQtvhiv13268EdHEI/aLOw2FN j1UUt44XjK5jvvB0CcEP =ja7q -----END PGP SIGNATURE----- --H0fDMKj3Um9qoHsuRgn0hO7GjHmd1oDLF-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH RFC 2/3] fbdev: move fbdev core files to separate directory Date: Fri, 14 Feb 2014 14:31:24 +0200 Message-ID: <52FE0C9C.6090905@ti.com> References: <1392376711-11290-1-git-send-email-tomi.valkeinen@ti.com> <1392376711-11290-2-git-send-email-tomi.valkeinen@ti.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="H0fDMKj3Um9qoHsuRgn0hO7GjHmd1oDLF" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Linux Fbdev development list , DRI Development , "linux-kernel@vger.kernel.org" , Laurent Pinchart , Jean-Christophe Plagniol-Villard , David Airlie List-Id: dri-devel@lists.freedesktop.org --H0fDMKj3Um9qoHsuRgn0hO7GjHmd1oDLF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 14/02/14 14:27, Geert Uytterhoeven wrote: > Hi Tomi, >=20 > Thanks for doing this! >=20 > Acked-by: Geert Uytterhoeven >=20 > On Fri, Feb 14, 2014 at 12:18 PM, Tomi Valkeinen wrote: >> --- a/drivers/video/fbdev/fbmon.c >> +++ b/drivers/video/fbdev/core/fbmon.c >> @@ -37,7 +37,7 @@ >> #include >> #include >> /* >> * EDID parserpci-bridge.h> >> #endif >> -#include "edid.h" >> +#include "../edid.h" >=20 > This looks a bit asymmetrical ... >=20 >> --- a/drivers/video/fbdev/wmt_ge_rops.c >> +++ b/drivers/video/fbdev/wmt_ge_rops.c >> @@ -18,7 +18,7 @@ >> #include >> #include >> #include >> -#include "fb_draw.h" >> +#include "core/fb_draw.h" >=20 > ... to this. >=20 > Perhaps (the content of) edid.h belongs in include/video/edid.h? Yes, I thought the same, but I didn't want to start messing around too much in this series. I also noticed some odd Kconfig options (for example, HAVE_FB_ATMEL, SH_MIPI_DSI, SH_LCD_MIPI_DSI at the beginning of drivers/video/Kconfig), which I almost started cleaning up, but decided to just concentrate on the main reorganization. Tomi --H0fDMKj3Um9qoHsuRgn0hO7GjHmd1oDLF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS/gyjAAoJEPo9qoy8lh715ugQAIUwVqQC15qPyjBynI7AsFEi JerkdL7p+vQvPquO/p0T/aBqjalZszWBxDw+VdC5ilo4ekqA8TIiGrmSYmKpSQuB IG0dnOo3wg3bZpZrTUPp8gKqN60olta3HmT89nUGuCdHJxtlC8BOcN+7NV0/Lix8 9Pw/OCug4pufvGxeCnJoGGL4fle+pKyxa5YsEdHdz0qic86SKs/tGy5+s/0xzsyA jr0U74LmNQMEuJzEd4/krCacRDFmoUj+29uWOaYhxIAshlqkIo0Ou2JY7U7V8ozP A06HE6nBLHAd3hLsjZYEG68mOuYmkBKEvJipaSzm9Q8+YU6dgjxyAaZtjl8KLdPc I4dBtsYKsURe8D7AJ0irK9M2VU2rCgc1UzMF0StwuNQDou79jTsPn7gg3m/BCQN3 Ig7xUXcoCYxe3rSBJEYWyzzVqe8rXuhMEJ8Bx7xCJabWSaYPPhgRP4jAgVe8TcvS rFI9Fz1LQO5cJA8A/eR4PG5wXZz9T6jEiukqkSglBe3EL8OkU7DqJvgCw+sh7dm5 ta8aMWQ9EohM0sgIXCSQxCwVdM1vri5mAyiDZ/sE0qVP31Zphrq8pgWAa5kkpxP9 Pc4zsq5BjrsdKn7as2c3JPK75u0lL8ZFrBhsuF3PQtvhiv13268EdHEI/aLOw2FN j1UUt44XjK5jvvB0CcEP =ja7q -----END PGP SIGNATURE----- --H0fDMKj3Um9qoHsuRgn0hO7GjHmd1oDLF--