From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Stanislawski Subject: Re: [PATCH v4 14/34] drm/exynos: hdmi: remove the i2c drivers and use devtree Date: Fri, 14 Feb 2014 15:13:24 +0100 Message-ID: <52FE2484.2090509@samsung.com> References: <1391116773-28471-1-git-send-email-seanpaul@chromium.org> <1391116773-28471-15-git-send-email-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by gabe.freedesktop.org (Postfix) with ESMTP id 6F2F9FB4CB for ; Fri, 14 Feb 2014 06:13:32 -0800 (PST) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N0Z00JESOUHYZ60@mailout3.w1.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 14 Feb 2014 14:13:29 +0000 (GMT) In-reply-to: <1391116773-28471-15-git-send-email-seanpaul@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Sean Paul , dri-devel@lists.freedesktop.org, inki.dae@samsung.com Cc: marcheu@chromium.org List-Id: dri-devel@lists.freedesktop.org Hi Daniel, I think that it would be better to change the semantic of phy and ddc bindings. Rather than pointing to I2C client it should point to I2C bus instead. The exynos DRM driver can create dummy I2C clients using i2c_new_dummy() function. There is quite strong rationale for this: - DDC is always accessible on fixed addresses described in HDMI specification. - HDMIPHY (including I2C address) is a part of HDMI IP and it is bound to specific version of Exynos SoC - no need to add virtual nodes in DTS - NVIDIA already use bindings to DDC bus instead of DDC client. Take a look to arch/arm/boot/dts/tegra*.dts Regards, Tomasz Stanislawski