Re: [Qemu-devel] [PATCH] qtest: include system headers before user headers

["Andreas Färber" <afaerber@suse.de>]

Am 14.02.2014 15:32, schrieb Stefan Hajnoczi:
> On Sat, Feb 08, 2014 at 11:41:07AM +0100, Stefan Hajnoczi wrote:
>> It is dangerous to include user headers before system headers since user
>> macros can affect system headers.
>>
>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>>  tests/endianness-test.c |  2 +-
>>  tests/fw_cfg-test.c     |  7 +++----
>>  tests/i440fx-test.c     | 11 +++++------
>>  tests/m48t59-test.c     |  3 ++-
>>  tests/qom-test.c        |  3 ++-
>>  tests/rtc-test.c        |  5 +++--
>>  tests/tmp105-test.c     |  5 +++--
>>  7 files changed, 19 insertions(+), 17 deletions(-)
> 
> Ping?

I felt it wasn't long enough on the list before my v1 PULL. I can pick
it up for v2, now that no one has objected.

> Is anyone willing to be qtest maintainer, i.e. you understand qtest, can
> review patches, and will send pull requests?

I don't feel like the official qtest maintainer, but I care and am
actively working on it. I would consider it best to have individual
tests maintained by subsystem maintainers and only define a maintainer
for the core libqtest.c/qtest.c code.

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg