From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WELFa-000452-Lw for qemu-devel@nongnu.org; Fri, 14 Feb 2014 11:04:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WELFU-0001wO-EA for qemu-devel@nongnu.org; Fri, 14 Feb 2014 11:04:26 -0500 Received: from cantor2.suse.de ([195.135.220.15]:48771 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WELFU-0001wG-8H for qemu-devel@nongnu.org; Fri, 14 Feb 2014 11:04:20 -0500 Message-ID: <52FE3E80.5060000@suse.de> Date: Fri, 14 Feb 2014 17:04:16 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1392391000-5687-1-git-send-email-sebastian.huber@embedded-brains.de> <52FE3761.7020403@suse.de> <52FE39B1.1020506@embedded-brains.de> In-Reply-To: <52FE39B1.1020506@embedded-brains.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3] target-sparc: Add and use CPU_FEATURE_CASA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sebastian Huber Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org, Fabien Chouteau Am 14.02.2014 16:43, schrieb Sebastian Huber: > On 2014-02-14 16:33, Andreas F=C3=A4rber wrote: >>> @@ -5120,6 +5119,20 @@ static void disas_sparc_insn(DisasContext * >>> dc, unsigned int insn) >>> > case 0x37: /* stdc */ >>> > goto ncp_insn; >>> > #endif >>> >+#if !defined(CONFIG_USER_ONLY) || defined(TARGET_SPARC64) >>> >+ case 0x3c: /* V9 or LEON3 casa */ >>> >+ CHECK_FPU_FEATURE(dc, CASA); >>> >+#ifndef TARGET_SPARC64 >>> >+ if (IS_IMM) >> >> Did you forget to run checkpatch.pl? Missing braces here ... >> >>> >+ goto illegal_insn; >>> >+ if (!supervisor(dc)) >> ... and here. >> >>> >+ goto priv_insn; >> Otherwise patch looks okay, thanks for the subject normalization. >=20 > I didn't know there was a checkpatch.pl, I run it next time. http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.ht= ml may be helpful then. :) There's also scripts/get_maintainer.pl --nogit-fallback. > This code fragment is a copy and paste move from another place in this > file. There a lot of similar style errors in this file. Our policy is to have new code adhere to the official Coding Style. If you want, you can do a two-patch series (in which case we ask for a cover letter...), with the initial one cleaning up the existing style faults and the second one doing the actual change. But to be clear, such cleanup of old code is entirely optional. >> As for the other one you'll need to sort our who sends a pull if Blue >> doesn't resurface - I note that qemu-trivial is not CC'ed here and the >> patch probably isn't anyway. Maybe Fabien can help out with that? >> >> More generally, independent of this patch with test case in its commit >> message, you may want to consider setting up tests/tcg/sparc/ for test >> cases and/or use qtest with accel=3Dtcg similar to what mst did for AC= PI >> regression testing. >=20 > Ok, I will have a look at this. Is this a required step to get the > patch committed? No, that was a forward-looking suggestion, seeing you providing a test case in the commit message. Cheers, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg