From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>, linux-can@vger.kernel.org
Subject: Re: [PATCH 2/4] can: netlink send bittiming data only when bittiming_const is available
Date: Sat, 15 Feb 2014 08:10:44 +0100 [thread overview]
Message-ID: <52FF12F4.5010905@hartkopp.net> (raw)
In-Reply-To: <52FE8A0B.6090405@pengutronix.de>
On 14.02.2014 22:26, Marc Kleine-Budde wrote:
> On 02/14/2014 09:57 PM, Oliver Hartkopp wrote:
>> The bittiming information is only valid when the CAN driver has a valid
>> structure of bittiming_const. Therefore provide the information of the
>> bittiming only when bittiming_const exists.
>
> What about intelligent CAN controllers which only support fixed
> bitrates? We once hat such a device and it was a design goal to support
> such devices.
>
>> This is also a preparation for the CAN FD specific bittiming_const structure
>> which is not existing in non-FD drivers. Therefore all the CAN FD bittiming
>> stuff has to be disabled when the CAN FD specific bittiming_const structure is
>> missing.
>
> Can we use bitrate == 0 as an indicator?
>
Good idea.
This is done in another place too.
Updated patchset sent.
How do I make it a "v2" ??
Regards,
Oliver
next prev parent reply other threads:[~2014-02-15 7:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 20:57 [PATCH 1/4] can: preserve skbuff protocol in can_put_echo_skb Oliver Hartkopp
2014-02-14 20:57 ` [PATCH 2/4] can: netlink send bittiming data only when bittiming_const is available Oliver Hartkopp
2014-02-14 21:26 ` Marc Kleine-Budde
2014-02-15 7:10 ` Oliver Hartkopp [this message]
2014-02-15 10:06 ` Marc Kleine-Budde
2014-02-14 20:57 ` [PATCH 3/4] can: provide a separate bittiming_const parameter to bittiming functions Oliver Hartkopp
2014-02-14 20:57 ` [PATCH 4/4] can: introduce a second bitrate for CAN FD data bitrate configuration Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FF12F4.5010905@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.