From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WEgXc-000342-1k for mharc-grub-devel@gnu.org; Sat, 15 Feb 2014 09:48:28 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEgXS-00032C-ET for grub-devel@gnu.org; Sat, 15 Feb 2014 09:48:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WEgXJ-0006fS-Tj for grub-devel@gnu.org; Sat, 15 Feb 2014 09:48:18 -0500 Received: from mout.gmx.net ([212.227.17.22]:52722) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEgXJ-0006eU-Jz for grub-devel@gnu.org; Sat, 15 Feb 2014 09:48:09 -0500 Received: from [192.168.1.1] ([31.34.87.55]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0LufbI-1VF7kj0os4-00zlBr for ; Sat, 15 Feb 2014 15:48:05 +0100 Message-ID: <52FF7E23.8030208@gmx.fr> Date: Sat, 15 Feb 2014 15:48:03 +0100 From: "Arbiel (gmx)" User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: meierfra@ubuntuforums.org Subject: Proposal for fixing bootinfoscript when grub v2.00 sits on the MBR Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:P8uNuEtD5jXekwrqErZWtu3KNYr5djReoBRRrn+zRnhAfdC2CpG Ed1t8krmaVCJJllWks06tq4PyY5lN0A1GDfyE1n3RUPXW5Slrf99PT4JTfXV2hm1D3L5zaF /r/mY5q0uzuvNoGEAvCsM3W8NqCeNr+N1SOAmPmzb1qGVHGxb7gFA6Gtu9V9IokJVr9/Mqe tPrGrQaT3hlj1nkKhsEFA== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.17.22 Cc: The development of GNU GRUB , "yannubuntu@gmail.com" X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Feb 2014 14:48:25 -0000 Hi Apparently, you are in charge of maintaining bootinfoscript. It turns out that the script does not correctly discriminate grub2's versions 1.99 and 2.00. To understand why, I've studied the release available for download at http://sourceforge.net/p/bootinfoscript/code/ci/master/tree/ and used by "boot-repair", a boot repairing tool written by YannUbuntu. I found out that the mistake comes from the fact that bootinfoscript looks in core.img for a 6-byte value of "d1 e9 df fe ff ff" and, when found, looks at the following two bytes for either "66 90" or "8d b6" to deduce that grub2's version is 2.00. For any other value, it deduces the version to be 1.99, whereas the latter should be deduced only from a "00 00" value, if the comments inside the script's code are reliable. I've installed grub2 v2.00 from a Ubuntu distribution and it happens that the two bytes following the "d1 e9 df fe ff ff" token hold a third value, namely "8d 76". I obviously do not know whether this third value is a "good" value to be considered as a grub v2.00 token or if the search for "d1 e9 df fe ff ff" should be continued until it reaches a "good" "00 00", "66 90" or "8d b6" value into the two following bytes. Could you please investigate this issue, and possibly update bootinfoscript ? Thank's in advance. Arbiel