From mboxrd@z Thu Jan 1 00:00:00 1970 From: emilio@elopez.com.ar (=?ISO-8859-1?Q?Emilio_L=F3pez?=) Date: Sat, 15 Feb 2014 12:18:00 -0300 Subject: [PATCH 1/2] clk: fixed-rate: use full DT node name In-Reply-To: <1392358613-19962-1-git-send-email-swarren@wwwdotorg.org> References: <1392358613-19962-1-git-send-email-swarren@wwwdotorg.org> Message-ID: <52FF8528.2020404@elopez.com.ar> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Stephen, El 14/02/14 03:16, Stephen Warren escribi?: > clk-fixed-rate currently names clocks according to a node's name without > the unit address. When faced with the legal and technically correct DT > structure below, this causes rgistration attempts for 3 clocks with the > same name, 2 of which fail. > > clocks { > compatible = "simple-bus"; > #address-cells = <1>; > #size-cells = <0>; > > clk_mmc: clock at 0 { > compatible = "fixed-clock"; > reg = <0>; > ... > clk_i2c: clock at 1 { > compatible = "fixed-clock"; > reg = <1>; > ... > clk_spi: clock at 2 { > compatible = "fixed-clock"; > reg = <2>; > ... > > Solve this by naming the clocks after the full node name rather than the > short version (e.g. /clocks/clock at 0). An alternative that doesn't require any change in the driver would be to use the optional but recommended clock-output-names property from the common clock binding. Your DT would then look something like the following > ... > clk_mmc: clk at 0 { > compatible = "fixed-clock"; > clock-output-names = "mmc"; > ... > clk_i2c: clk at 1 { > compatible = "fixed-clock"; > clock-output-names = "i2c"; > ... > clk_spi: clk at 2 { > compatible = "fixed-clock"; > clock-output-names = "spi"; > ... Cheers, Emilio From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Emilio_L=F3pez?= Subject: Re: [PATCH 1/2] clk: fixed-rate: use full DT node name Date: Sat, 15 Feb 2014 12:18:00 -0300 Message-ID: <52FF8528.2020404@elopez.com.ar> References: <1392358613-19962-1-git-send-email-swarren@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1392358613-19962-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren , Mike Turquette Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hello Stephen, El 14/02/14 03:16, Stephen Warren escribi=F3: > clk-fixed-rate currently names clocks according to a node's name with= out > the unit address. When faced with the legal and technically correct D= T > structure below, this causes rgistration attempts for 3 clocks with t= he > same name, 2 of which fail. > > clocks { > compatible =3D "simple-bus"; > #address-cells =3D <1>; > #size-cells =3D <0>; > > clk_mmc: clock@0 { > compatible =3D "fixed-clock"; > reg =3D <0>; > ... > clk_i2c: clock@1 { > compatible =3D "fixed-clock"; > reg =3D <1>; > ... > clk_spi: clock@2 { > compatible =3D "fixed-clock"; > reg =3D <2>; > ... > > Solve this by naming the clocks after the full node name rather than = the > short version (e.g. /clocks/clock@0). An alternative that doesn't require any change in the driver would be t= o=20 use the optional but recommended clock-output-names property from the=20 common clock binding. Your DT would then look something like the following > ... > clk_mmc: clk@0 { > compatible =3D "fixed-clock"; > clock-output-names =3D "mmc"; > ... > clk_i2c: clk@1 { > compatible =3D "fixed-clock"; > clock-output-names =3D "i2c"; > ... > clk_spi: clk@2 { > compatible =3D "fixed-clock"; > clock-output-names =3D "spi"; > ... Cheers, Emilio -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html