From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 7/7] xen: Convert __page_to_mfn and __mfn_to_page to use typesafe MFN Date: Thu, 5 Oct 2017 00:27:37 +0100 Message-ID: <52aab653-7e67-7a6f-5b73-175353f29ab1@citrix.com> References: <20171004181526.9405-1-julien.grall@linaro.org> <20171004181526.9405-8-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171004181526.9405-8-julien.grall@linaro.org> Content-Language: en-GB List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Julien Grall , xen-devel@lists.xen.org Cc: Jun Nakajima , Kevin Tian , Stefano Stabellini , Wei Liu , Suravee Suthikulpanit , Razvan Cojocaru , Konrad Rzeszutek Wilk , George Dunlap , Tim Deegan , Ian Jackson , Julien Grall , Tamas K Lengyel , Jan Beulich , Shane Wang , Boris Ostrovsky , Gang Wei , Paul Durrant List-Id: xen-devel@lists.xenproject.org T24gMDQvMTAvMjAxNyAxOToxNSwgSnVsaWVuIEdyYWxsIHdyb3RlOgo+IGRpZmYgLS1naXQgYS94 ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMK PiBpbmRleCAwOTNlYmYxYThlLi4wNzUzZDAzYWFjIDEwMDY0NAo+IC0tLSBhL3hlbi9hcmNoL2Fy bS9kb21haW5fYnVpbGQuYwo+ICsrKyBiL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYwo+IEBA IC0xMDQsMTEgKzEwNCwxMSBAQCBzdGF0aWMgYm9vbCBpbnNlcnRfMTFfYmFuayhzdHJ1Y3QgZG9t YWluICpkLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgb3JkZXIp Cj4gIHsKPiAgICAgIGludCByZXMsIGk7Cj4gLSAgICBwYWRkcl90IHNwZm47Cj4gKyAgICBtZm5f dCBzbWZuOwo+ICAgICAgcGFkZHJfdCBzdGFydCwgc2l6ZTsKPiAgCj4gLSAgICBzcGZuID0gcGFn ZV90b19tZm4ocGcpOwo+IC0gICAgc3RhcnQgPSBwZm5fdG9fcGFkZHIoc3Bmbik7Cj4gKyAgICBz bWZuID0gcGFnZV90b19tZm4ocGcpOwo+ICsgICAgc3RhcnQgPSBtZm5fdG9fbWFkZHIoc21mbik7 Cj4gICAgICBzaXplID0gcGZuX3RvX3BhZGRyKDFVTCA8PCBvcmRlcik7CgpXb3VsZG4ndCBpdCBi ZSBjbGVhbmVyIHRvIG1vdmUgdGhpcyByZW5hbWluZyBpbnRvIHBhdGNoIDEsIGFsb25nIHdpdGgg YW4KZXh0cmEgc2V0IG9mIHVuZGVmL292ZXJyaWRlLCB0byBiZSB0YWtlbiBvdXQgaGVyZT/CoCAo cGVyaGFwcyBub3QgZ2l2ZW4KdGhlIHJld29yayBlZmZvcnQ/KQoKPiAgCj4gICAgICBEMTFQUklO VCgiQWxsb2NhdGVkICUjIlBSSXBhZGRyIi0lIyJQUklwYWRkciIgKCVsZE1CLyVsZE1CLCBvcmRl ciAlZClcbiIsCj4gQEAgLTY3OCw4ICs2NzgsOCBAQCBzdGF0aWMgdm9pZCBwdnBtdV9maW5pc2go c3RydWN0IGRvbWFpbiAqZCwgeGVuX3BtdV9wYXJhbXNfdCAqcGFyYW1zKQo+ICAKPiAgICAgIGlm ICggeGVucG11X2RhdGEgKQo+ICAgICAgewo+IC0gICAgICAgIG1mbiA9IGRvbWFpbl9wYWdlX21h cF90b19tZm4oeGVucG11X2RhdGEpOwo+IC0gICAgICAgIEFTU0VSVChtZm5fdmFsaWQoX21mbiht Zm4pKSk7Cj4gKyAgICAgICAgbWZuID0gX21mbihkb21haW5fcGFnZV9tYXBfdG9fbWZuKHhlbnBt dV9kYXRhKSk7CgpTZWVpbmcgYXMgeW91IGNvbnZlcnQgZXZlcnkoPykgY2FsbCB0byBkb21haW5f cGFnZV9tYXBfdG9fbWZuKCksIGl0CndvdWxkIGJlIGNsZWFuZXIgdG8gY2hhbmdlIHRoZSByZXR1 cm4gdHlwZSB3aGlsZSBtYWtpbmcgdGhlIGNoYW5nZS4KCkknZCBiZSBoYXBweSBmb3Igc3VjaCBh IGNoYW5nZSBiZWluZyBmb2xkZWQgaW50byB0aGlzIHBhdGNoLCBiZWNhdXNlCmRvaW5nIHNvIHdv dWxkIGJlIGJ5IGZhciB0aGUgbGVhc3QgZGlzcnVwdGl2ZSB3YXkgb2YgbWFraW5nIHRoZSBjaGFu Z2UuCgo+ICsgICAgICAgIEFTU0VSVChtZm5fdmFsaWQobWZuKSk7Cj4gICAgICAgICAgdW5tYXBf ZG9tYWluX3BhZ2VfZ2xvYmFsKHhlbnBtdV9kYXRhKTsKPiAgICAgICAgICBwdXRfcGFnZV9hbmRf dHlwZShtZm5fdG9fcGFnZShtZm4pKTsKPiAgICAgIH0KPiBAQCAtMTE4NSw4ICsxMTgwLDggQEAg aW50IF9fbWVtX3NoYXJpbmdfdW5zaGFyZV9wYWdlKHN0cnVjdCBkb21haW4gKmQsCj4gICAgICAg ICAgcmV0dXJuIC1FTk9NRU07Cj4gICAgICB9Cj4gIAo+IC0gICAgcyA9IG1hcF9kb21haW5fcGFn ZShfbWZuKF9fcGFnZV90b19tZm4ob2xkX3BhZ2UpKSk7Cj4gLSAgICB0ID0gbWFwX2RvbWFpbl9w YWdlKF9tZm4oX19wYWdlX3RvX21mbihwYWdlKSkpOwo+ICsgICAgcyA9IG1hcF9kb21haW5fcGFn ZShwYWdlX3RvX21mbihvbGRfcGFnZSkpOwo+ICsgICAgdCA9IG1hcF9kb21haW5fcGFnZShwYWdl X3RvX21mbihwYWdlKSk7Cj4gICAgICBtZW1jcHkodCwgcywgUEFHRV9TSVpFKTsKPiAgICAgIHVu bWFwX2RvbWFpbl9wYWdlKHMpOwo+ICAgICAgdW5tYXBfZG9tYWluX3BhZ2UodCk7CgpUaGlzIHdo b2xlIGxvdCBjb3VsZCB0dXJuIGludG8gY29weV9kb21haW5fcGFnZSgpCgo+IGRpZmYgLS1naXQg YS94ZW4vYXJjaC94ODYvcHYvZGVzY3JpcHRvci10YWJsZXMuYyBiL3hlbi9hcmNoL3g4Ni9wdi9k ZXNjcmlwdG9yLXRhYmxlcy5jCj4gaW5kZXggODE5NzNhZjEyNC4uMzcxMjIxYTMwMiAxMDA2NDQK PiAtLS0gYS94ZW4vYXJjaC94ODYvcHYvZGVzY3JpcHRvci10YWJsZXMuYwo+ICsrKyBiL3hlbi9h cmNoL3g4Ni9wdi9kZXNjcmlwdG9yLXRhYmxlcy5jCj4gQEAgLTI1LDEyICsyNSw2IEBACj4gICNp bmNsdWRlIDxhc20vcDJtLmg+Cj4gICNpbmNsdWRlIDxhc20vcHYvbW0uaD4KPiAgCj4gLS8qIE92 ZXJyaWRlIG1hY3JvcyBmcm9tIGFzbS9wYWdlLmggdG8gbWFrZSB0aGVtIHdvcmsgd2l0aCBtZm5f dCAqLwo+IC0jdW5kZWYgbWZuX3RvX3BhZ2UKPiAtI2RlZmluZSBtZm5fdG9fcGFnZShtZm4pIF9f bWZuX3RvX3BhZ2UobWZuX3gobWZuKSkKPiAtI3VuZGVmIHBhZ2VfdG9fbWZuCj4gLSNkZWZpbmUg cGFnZV90b19tZm4ocGcpIF9tZm4oX19wYWdlX3RvX21mbihwZykpCj4gLQo+ICAvKioqKioqKioq KioqKioqKioqKgo+ICAgKiBEZXNjcmlwdG9yIFRhYmxlcwo+ICAgKi8KCklmIHlvdSdyZSBtYWtp bmcgdGhpcyBjaGFuZ2UsIHBsZWFzZSB0YWtlIG91dCB0aGUgRGVzY3JpcHRvciBUYWJsZXMKY29t bWVudCBsaWtlIHlvdSBkbyB3aXRoIEkvTyBiZWxvdywgYmVjYXVzZSB0aGUgZW50aXJlIGZpbGUg aXMgZGVkaWNhdGVkCnRvIGRlc2NyaXB0b3IgdGFibGUgc3VwcG9ydCBhbmQgaXQgd2lsbCBzYXZl IG1lIG9uZSBpdGVtIG9uIGEgY2xlYW51cApwYXRjaCA6KS4KCj4gZGlmZiAtLWdpdCBhL3hlbi9h cmNoL3g4Ni9wdi9lbXVsLXByaXYtb3AuYyBiL3hlbi9hcmNoL3g4Ni9wdi9lbXVsLXByaXYtb3Au Ywo+IGluZGV4IGRkOTA3MTNhY2YuLjljY2JkMDIxZWYgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gv eDg2L3B2L2VtdWwtcHJpdi1vcC5jCj4gKysrIGIveGVuL2FyY2gveDg2L3B2L2VtdWwtcHJpdi1v cC5jCj4gQEAgLTQzLDE2ICs0Myw2IEBACj4gICNpbmNsdWRlICJlbXVsYXRlLmgiCj4gICNpbmNs dWRlICJtbS5oIgo+ICAKPiAtLyogT3ZlcnJpZGUgbWFjcm9zIGZyb20gYXNtL3BhZ2UuaCB0byBt YWtlIHRoZW0gd29yayB3aXRoIG1mbl90ICovCj4gLSN1bmRlZiBtZm5fdG9fcGFnZQo+IC0jZGVm aW5lIG1mbl90b19wYWdlKG1mbikgX19tZm5fdG9fcGFnZShtZm5feChtZm4pKQo+IC0jdW5kZWYg cGFnZV90b19tZm4KPiAtI2RlZmluZSBwYWdlX3RvX21mbihwZykgX21mbihfX3BhZ2VfdG9fbWZu KHBnKSkKPiAtCj4gLS8qKioqKioqKioqKioqKioqKioqKioqKgo+IC0gKiBJL08gZW11bGF0aW9u IHN1cHBvcnQKPiAtICovCj4gLQo+ICBzdHJ1Y3QgcHJpdl9vcF9jdHh0IHsKPiAgICAgIHN0cnVj dCB4ODZfZW11bGF0ZV9jdHh0IGN0eHQ7Cj4gICAgICBzdHJ1Y3Qgewo+IEBAIC04NzMsMjIgKzg3 MywyMiBAQCBpbnQga2ltYWdlX2J1aWxkX2luZChzdHJ1Y3Qga2V4ZWNfaW1hZ2UgKmltYWdlLCB1 bnNpZ25lZCBsb25nIGluZF9tZm4sCj4gICAgICBmb3IgKCBlbnRyeSA9IHBhZ2U7IDsgICkKPiAg ICAgIHsKPiAgICAgICAgICB1bnNpZ25lZCBsb25nIGluZDsKPiAtICAgICAgICB1bnNpZ25lZCBs b25nIG1mbjsKPiArICAgICAgICBtZm5fdCBtZm47Cj4gIAo+ICAgICAgICAgIGluZCA9IGtpbWFn ZV9lbnRyeV9pbmQoZW50cnksIGNvbXBhdCk7Cj4gLSAgICAgICAgbWZuID0ga2ltYWdlX2VudHJ5 X21mbihlbnRyeSwgY29tcGF0KTsKPiArICAgICAgICBtZm4gPSBfbWZuKGtpbWFnZV9lbnRyeV9t Zm4oZW50cnksIGNvbXBhdCkpOwoKQWdhaW4sIG1vZGlmeSB0aGUgcmV0dXJuIHR5cGUgb2Yga2lt YWdlX2VudHJ5X21mbigpID8KCj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL2FzbS14ODYvcGFn ZS5oIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9wYWdlLmgKPiBpbmRleCA0NWNhNzQyNjc4Li44NzM3 ZWYxNmZmIDEwMDY0NAo+IC0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvcGFnZS5oCj4gKysrIGIv eGVuL2luY2x1ZGUvYXNtLXg4Ni9wYWdlLmgKPiBAQCAtMjczLDggKzI3Myw4IEBAIHZvaWQgY29w eV9wYWdlX3NzZTIodm9pZCAqLCBjb25zdCB2b2lkICopOwo+ICAjZGVmaW5lIHBmbl90b19wYWRk cihwZm4pICAgX19wZm5fdG9fcGFkZHIocGZuKQo+ICAjZGVmaW5lIHBhZGRyX3RvX3BmbihwYSkg ICAgX19wYWRkcl90b19wZm4ocGEpCj4gICNkZWZpbmUgcGFkZHJfdG9fcGR4KHBhKSAgICBwZm5f dG9fcGR4KHBhZGRyX3RvX3BmbihwYSkpCj4gLSNkZWZpbmUgdm1hcF90b19tZm4odmEpICAgICBs MWVfZ2V0X3BmbigqdmlydF90b194ZW5fbDFlKCh1bnNpZ25lZCBsb25nKSh2YSkpKQo+IC0jZGVm aW5lIHZtYXBfdG9fcGFnZSh2YSkgICAgbWZuX3RvX3BhZ2Uodm1hcF90b19tZm4odmEpKQo+ICsj ZGVmaW5lIHZtYXBfdG9fbWZuKHZhKSAgICAgX21mbihsMWVfZ2V0X3BmbigqdmlydF90b194ZW5f bDFlKCh1bnNpZ25lZCBsb25nKSh2YSkpKSkKCmwxZV9nZXRfbWZuKCp2aXJ0X3RvX3hlbl9sMWUo KHVuc2lnbmVkIGxvbmcpKHZhKSkpCgo+ICsjZGVmaW5lIHZtYXBfdG9fcGFnZSh2YSkgICAgX19t Zm5fdG9fcGFnZSh2bWFwX3RvX21mbih2YSkpCj4gIAo+ICAjZW5kaWYgLyogIWRlZmluZWQoX19B U1NFTUJMWV9fKSAqLwo+ICAKPiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUveGVuL3RtZW1feGVu LmggYi94ZW4vaW5jbHVkZS94ZW4vdG1lbV94ZW4uaAo+IGluZGV4IDU0MmMwYjNmMjAuLjg1MTZh MGIxMzEgMTAwNjQ0Cj4gLS0tIGEveGVuL2luY2x1ZGUveGVuL3RtZW1feGVuLmgKPiArKysgYi94 ZW4vaW5jbHVkZS94ZW4vdG1lbV94ZW4uaAo+IEBAIC0yNSw3ICsyNSw3IEBACj4gIHR5cGVkZWYg dWludDMyX3QgcGFnZXNpemVfdDsgIC8qIGxpa2Ugc2l6ZV90LCBtdXN0IGhhbmRsZSBsYXJnZXN0 IFBBR0VfU0laRSAqLwo+ICAKPiAgI2RlZmluZSBJU19QQUdFX0FMSUdORUQoYWRkcikgSVNfQUxJ R05FRCgodW5zaWduZWQgbG9uZykoYWRkciksIFBBR0VfU0laRSkKPiAtI2RlZmluZSBJU19WQUxJ RF9QQUdFKF9waSkgICAgbWZuX3ZhbGlkKF9tZm4ocGFnZV90b19tZm4oX3BpKSkpCj4gKyNkZWZp bmUgSVNfVkFMSURfUEFHRShfcGkpICAgIG1mbl92YWxpZChwYWdlX3RvX21mbihfcGkpKQoKL3Np Z2jCoCBUaGlzIGlzIHRhdXRvbG9naWNhbC7CoCBUaGUgZGVmaW5pdGlvbiBvZiBhICJ2YWxpZCBt Zm4iIGluIHRoaXMKY2FzZSBpcyBvbmUgZm9yIHdoaWNoIHdlIGhhdmUgZnJhbWV0YWJsZSBlbnRy eSwgYW5kIGJ5IGhhdmluZyBhIHN0cnVjdApwYWdlX2luZm8gaW4gb3VyIGhhbmRzLCB0aGlzIGlz IGJ5IGRlZmluaXRpb24gdHJ1ZSAodW5sZXNzIHlvdSBoYXZlIGEKd2lsZCBwb2ludGVyLCBhdCB3 aGljaCBwb2ludCB5b3VyIGJ1ZyBpcyBlbHNld2hlcmUpLgoKSVNfVkFMSURfUEFHRSgpIGlzIG9u bHkgZXZlciB1c2VkIGluIGFzc2VydGlvbnMgYW5kIG5ldmVyIHVzZWZ1bGx5LCBzbwppbnN0ZWFk IEkgd291bGQgcmVtb3ZlIGl0IGVudGlyZWx5IHJhdGhlciB0aGFuIHRyeWluZyB0byBmaXggaXQg dXAuCgpBcyBmb3IgVE1FTSBpdHNlbGYgKEp1bGllbjogVGhpcyBteSBubyBtZWFucyBibG9ja3Mg dGhlIHBhdGNoLsKgIEl0IGlzCm1vcmUgYW4gb2JzZXJ2YXRpb24gZm9yIEtvbnJhZCB0byBzZWUg YWJvdXQgZml4aW5nKSwgSSBzZWUgdGhhdCBUTUVNIGlzCmJyb2tlbiBvbiB4ODYgbWFjaGluZXMg d2l0aCBtb3JlIHRoYW4gNVRCIG9mIFJBTSwgYmVjYXVzZSBpdCBpcyBub3QKbGVnYWwgdG8gY2Fs bCBwYWdlX3RvX3ZpcnQoKSBvbiBhIHN0cnVjdCBwYWdlX2luZm8gYWxsb2NhdGVkIGZyb20gdGhl CmRvbWhlYXAgKHdoaWNoIGlzIHdoeSBhbGxvY194ZW5oZWFwX3BhZ2UoKSByZXR1cm5zIGEgdm9p ZCAqLCBhbmQKYWxsb2NfZG9taGVhcF9wYWdlKCkgc3BlY2lmaWNhbGx5IGRvZXNuJ3QpLsKgIFRo ZSBlYXN5IGZpeCBmb3IgdGhpcyBpcyB0bwpzd2FwIHRoZSBhbGxvY2F0aW9uIHByaW1pdGl2ZXMg b3ZlciB0byB1c2luZyB4ZW5oZWFwIGFsbG9jYXRpb25zLCB3aGljaAp3b3VsZCByZW1vdmUgdGhl IG5lZWQgZm9yIHBhZ2VfdG9fdmlydCgpIGFuZCBiYWNrLCBvciBhIGJldHRlciBmaXggd291bGQK YmUgdG8gbm90IHBhc3MgZXZlcnl0aGluZyB0aGluZyBieSB2aXJ0dWFsIGFkZHJlc3MgKGF0IHdo aWNoIHBvaW50CnJldGFpbmluZyB1c2Ugb2YgdGhlIGRvbWhlYXAgaXMgZmluZSkuCgp+QW5kcmV3 CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2 ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVu Lm9yZy94ZW4tZGV2ZWwK