From: Roland Dreier <roland@topspin.com>
To: Andi Kleen <ak@muc.de>
Cc: "Nguyen, Tom L" <tom.l.nguyen@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [broken?] Add MSI support to e1000
Date: Tue, 24 Aug 2004 07:19:36 -0700 [thread overview]
Message-ID: <52acwksjnr.fsf@topspin.com> (raw)
In-Reply-To: <20040823233920.GA29854@muc.de> (Andi Kleen's message of "24 Aug 2004 01:39:20 +0200, Tue, 24 Aug 2004 01:39:20 +0200")
Andi> Yes, the flag word is 0x8b after the call. And
Andi> pci_enable_msi returns 0.
Actually I bet the problem is that the driver is doing request_irq()
on the wrong IRQ. In s2io.c, s2io_init_nic() does
sp->irq = pdev->irq;
and then sometime later s2io_open() does
err =
request_irq((int) sp->irq, s2io_isr, SA_SHIRQ, sp->name, dev);
If you put the call to pci_enable_msi() after sp->irq is assigned, the
driver will request the original irq (which will still be in INTx
mode, of course), rather than the new vector assigned by the MSI core.
- Roland
next prev parent reply other threads:[~2004-08-24 14:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-23 19:41 [PATCH] [broken?] Add MSI support to e1000 Nguyen, Tom L
2004-08-23 23:39 ` Andi Kleen
2004-08-24 14:19 ` Roland Dreier [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-08-24 17:40 Nguyen, Tom L
2004-08-24 16:01 Nguyen, Tom L
2004-08-23 23:17 Nguyen, Tom L
2004-08-24 2:15 ` Roland Dreier
2004-08-23 19:09 Nguyen, Tom L
2004-08-23 19:39 ` Roland Dreier
[not found] <2wpoS-1ai-1@gated-at.bofh.it>
[not found] ` <2wqXF-2jm-29@gated-at.bofh.it>
2004-08-23 18:17 ` Andi Kleen
2004-08-23 18:26 ` Roland Dreier
2004-08-23 15:41 Nguyen, Tom L
2004-08-23 17:25 ` Roland Dreier
2004-08-24 21:49 ` Chris Leech
2004-08-24 23:36 ` Roland Dreier
2004-08-20 21:37 Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52acwksjnr.fsf@topspin.com \
--to=roland@topspin.com \
--cc=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.