From: Damien Le Moal <dlemoal@kernel.org>
To: Sergei Shtylyov <sergei.shtylyov@gmail.com>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: John Garry <john.g.garry@oracle.com>, Jason Yan <yanaijie@huawei.com>
Subject: Re: [PATCH 3/3] ata: libata-scsi: Use ata_ncq_supported in ata_scsi_dev_config()
Date: Mon, 5 Jun 2023 18:48:12 +0900 [thread overview]
Message-ID: <52b11e92-0550-d6c7-6674-6d84a3622d40@kernel.org> (raw)
In-Reply-To: <7ccf4d9e-783a-1cec-ea94-81981a6976d1@gmail.com>
On 6/5/23 18:47, Sergei Shtylyov wrote:
> On 6/5/23 4:32 AM, Damien Le Moal wrote:
>
>> In ata_scsi_dev_config(), instead of hardconing the test to check if
>
> Again, hardcoding?
Yes... Square fingers today :)
>
>> an ATA device supports NCQ by looking at the ATA_DFLAG_NCQ flag, use
>> ata_ncq_supported().
>>
>> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> [...]
>
> MBR, Sergey
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2023-06-05 9:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 1:32 [PATCH 0/3] Cleanups and improvements Damien Le Moal
2023-06-05 1:32 ` [PATCH 1/3] ata: libata-sata: Improve ata_change_queue_depth() Damien Le Moal
2023-06-05 7:57 ` Hannes Reinecke
2023-06-05 9:58 ` John Garry
2023-06-05 10:40 ` Damien Le Moal
2023-06-05 1:32 ` [PATCH 2/3] ata: libata-eh: Use ata_ncq_enabled() in ata_eh_speed_down() Damien Le Moal
2023-06-05 7:57 ` Hannes Reinecke
2023-06-05 9:45 ` Sergei Shtylyov
2023-06-05 9:47 ` Damien Le Moal
2023-06-05 12:31 ` John Garry
2023-06-05 1:32 ` [PATCH 3/3] ata: libata-scsi: Use ata_ncq_supported in ata_scsi_dev_config() Damien Le Moal
2023-06-05 8:04 ` Hannes Reinecke
2023-06-05 9:37 ` Damien Le Moal
2023-06-05 9:46 ` Hannes Reinecke
2023-06-05 9:58 ` Damien Le Moal
2023-06-05 9:47 ` Sergei Shtylyov
2023-06-05 9:48 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52b11e92-0550-d6c7-6674-6d84a3622d40@kernel.org \
--to=dlemoal@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sergei.shtylyov@gmail.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.