From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1hRgPP-0007K2-RM for mharc-grub-devel@gnu.org; Fri, 17 May 2019 13:12:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRgPN-0007Jv-Ce for grub-devel@gnu.org; Fri, 17 May 2019 13:12:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRgPM-0003LA-FO for grub-devel@gnu.org; Fri, 17 May 2019 13:12:37 -0400 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]:43618) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hRgPM-0003JU-AN for grub-devel@gnu.org; Fri, 17 May 2019 13:12:36 -0400 Received: by mail-ot1-x343.google.com with SMTP id i8so7356692oth.10 for ; Fri, 17 May 2019 10:12:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=BXjhSqWRm+7enQNhJ8mbpFMCWlqcy5qn977PVT7ZVAo=; b=pR51WI9xNGyMmq3l4B3oydV/hDEJuNppH+7C+PnRMeVA4eKjZDPU5zKzF/rixxKNuA g2lkWnZrG6CFbjfB2bLrrnO1FJkytbu5v8pbW+kWsBqbG7kkPMA0z1xCJM6QaB01wICX hFqMWEnSzpGNsYYZNq1OYsLb2e0lmudw1GND1nX8Xjxgnp+tUAxHjG1YICniyxU0Q/cx T4z3flmoaddzBa1NscxJ6D9HjXioXrmD89SaexyzBRMXDi3I7CroRTAe0OBVK0nNprIp 7VlaTzXPNv6exLQN7B0CPbUg7+AHc8x0TWhbKmvgrVBt+J3CZjhngjW8Urc2u4cIRdmu XPUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BXjhSqWRm+7enQNhJ8mbpFMCWlqcy5qn977PVT7ZVAo=; b=RrnkkST4R5nKc4rXnWu3Ka3SQ4X96TvcshujS1z0uQSoU64CJAiZ2+YLkRDlh0hjhO gax3SPMCXEKqx1QuMqsg4Dxtz0Ow9YNgZ078RNHIU60r6qWntm01xSsQZN1J+iet4ep0 2AVN2NB4WwXOwMUz7jVMxfciGQOOHBi4xl/p6SAbuVD/BvHN3RGSFXg+rvUfKkGcCvYZ jk5ynfwksCy4dQx7OXhF7XDVeNepguxxsuvQcDSXqRAUdLPFELgWcDrSbVpmLRMTJpRr NX8aRLTKnQ+AyffY/FvpcooixWgcz2tUj52sMJ8Qg3ccZVeC80mzuREdK9Dj00aqFjGG iIvQ== X-Gm-Message-State: APjAAAUq5kFPC2T+gCO8IrvXaTFtXmEdK65oUynFo/qjoR42IPFDrfpw jQXv67iNwzNlCVjfzvH5xCHd1qoy X-Google-Smtp-Source: APXvYqwuS5O5QCHJVjoNMwvgFCyHoe0ZPKvTG1wyLMdmntAQYQydHeZZsKng+OUIMIM+1TqCrNlOpw== X-Received: by 2002:a9d:5912:: with SMTP id t18mr6661577oth.252.1558113154387; Fri, 17 May 2019 10:12:34 -0700 (PDT) Received: from [192.168.0.84] (cpe-70-123-227-116.satx.res.rr.com. [70.123.227.116]) by smtp.gmail.com with ESMTPSA id 92sm725828otw.7.2019.05.17.10.12.32 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 17 May 2019 10:12:33 -0700 (PDT) Subject: Re: gcc9.1 and f2fs To: grub-devel@gnu.org References: <20190517071320.GC31228@mazu> From: Bruce Dubbs Message-ID: <52c54c16-1e5e-2fc4-7d67-cc01857f68d9@gmail.com> Date: Fri, 17 May 2019 12:12:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190517071320.GC31228@mazu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::343 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 May 2019 17:12:38 -0000 On 5/17/19 2:13 AM, Michael Chang wrote: > Hello John, > > Except for lacking commit message and SOB, the fix is LGTM. [snip] >> --- >> grub-core/fs/f2fs.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/grub-core/fs/f2fs.c b/grub-core/fs/f2fs.c >> index 1cad2615f..0dd09bc23 100644 >> --- a/grub-core/fs/f2fs.c >> +++ b/grub-core/fs/f2fs.c >> @@ -1235,6 +1235,12 @@ grub_f2fs_utf16_to_utf8 (grub_uint16_t *in_buf_le) >> return out_buf; >> } >> >> + >> +#if __GNUC__ >= 9 >> +#pragma GCC diagnostic push >> +#pragma GCC diagnostic ignored "-Waddress-of-packed-member" >> +#endif >> + >> static grub_err_t >> grub_f2fs_label (grub_device_t device, char **label) >> { >> @@ -1255,6 +1261,10 @@ grub_f2fs_label (grub_device_t device, char **label) >> return grub_errno; >> } >> >> +#if __GNUC__ >= 9 >> +#pragma GCC diagnostic pop >> +#endif >> + >> static grub_err_t >> grub_f2fs_uuid (grub_device_t device, char **uuid) >> { I would like to point out that it is not a good idea to make a stable release using -Werror as a default. It is fine for development, but grub has traditionally taken a long time between stable releases (version 2.00 was in 2012 and version 2.02 was in 2017). After release, a new version of a compiler has a high probability of producing more warnings, which will break the build if using -Werrror. At linuxfromscratch we add --disable-werror, but it really shouldn't be needed. -- Bruce