Re: [PATCH i-g-t v3 5/7] tests/intel/xe_pxp: Test PXP submissions

["Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>]

looks good.

Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com>

On Wed, 2025-02-12 at 16:38 -0800, Ceraolo Spurio, Daniele wrote:
> The render supports PXP usage via rendercopy. We can use this to test
> that a user is able to correctly encrypt their data. In particular, we
> cover these 2 scenarios:
> 
> 1) copy from clear to encrypted - we expect the dest buffer to not match
>    the src one due to the encryption.
> 
> 2) copy from encrypted to encrypted = we expect the 2 BOs to match since
>    they hold the same data encrypted with the same key.
> 
> Note that the clear to clear copy is already covered by the
> xe_render_copy test, while encrypted to clear is obviously not a
> supported case.
> 
> Since the render_copy uses the intel_batchbuffer helpers, those helpers
> have been updated to support vm bind of protected objects.
> 
> v2: move igt_require calls inside the subtest
> v3: Better comments for rsvd1 overload, rename variables for clarity,
> updated commit msg.
> 
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
> ---
>  lib/intel_batchbuffer.c |  37 ++++--

alan:snip