From: Roland Dreier <roland@topspin.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Greg KH <greg@kroah.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: avoiding pci_disable_device()...
Date: Mon, 14 Feb 2005 11:58:38 -0800 [thread overview]
Message-ID: <52hdke29sh.fsf@topspin.com> (raw)
In-Reply-To: <4211013E.6@pobox.com> (Jeff Garzik's message of "Mon, 14 Feb 2005 14:51:26 -0500")
Jeff> * pci_request_regions() should be axiomatic. By that I mean,
Jeff> pci_enable_device() should
Jeff> (a) handle pci_request_regions() completely
Jeff> (b) fail if regions are not available
There's one pitfall here: for a device using MSI-X, the MSI-X table is
going to be somewhere in one of the device's BARs. When the device
driver does pci_enable_msix(), drivers/pci/msi.c will do
request_region() on this table. If the device driver has already done
pci_request_regions(), then this will fail and the driver won't be
able to use MSI-X. The current solution is for the driver to avoid
requesting the whole BAR where the MSI-X table is.
- R.
next prev parent reply other threads:[~2005-02-14 19:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-14 1:42 avoiding pci_disable_device() Jeff Garzik
2005-02-14 19:06 ` Greg KH
2005-02-14 18:08 ` Alan Cox
2005-02-14 19:24 ` Takashi Iwai
2005-02-14 19:34 ` Greg KH
2005-02-14 19:50 ` Takashi Iwai
2005-02-14 19:54 ` Jeff Garzik
2005-02-14 19:51 ` Jeff Garzik
2005-02-14 19:58 ` Roland Dreier [this message]
2005-02-14 20:00 ` Jeff Garzik
2005-02-14 21:42 ` Roland Dreier
2005-02-14 22:25 ` Jeff Garzik
2005-02-14 22:46 ` Roland Dreier
2005-02-17 23:07 ` Greg KH
2005-02-14 20:02 ` Arjan van de Ven
2005-02-15 2:05 ` Jeff Garzik
2005-02-16 11:27 ` Takashi Iwai
2005-02-16 13:44 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2005-02-14 10:43 Michal Rokos
2005-02-14 11:08 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52hdke29sh.fsf@topspin.com \
--to=roland@topspin.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.