From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roland Dreier <roland@topspin.com>
Date: Tue, 18 Jan 2005 17:19:40 +0000
Subject: Re: [openib-general] Re: [KJ] [RFC] TODO file cleanups
Message-Id: <52llaqejtf.fsf@topspin.com>
MIME-Version: 1
Content-Type: multipart/mixed; boundary="===============039054443850304876=="
List-Id: <kernel-janitors.vger.kernel.org>
References: <20050117231123.GC19162@nd47.coderock.org>
In-Reply-To: <20050117231123.GC19162@nd47.coderock.org>
To: kernel-janitors@vger.kernel.org

--===============039054443850304876==
Content-Type: text/plain; charset=us-ascii

    Matthew> Funny you should mention that.

    Matthew> drivers/infiniband/ulp/ipoib/ipoib_ib.c: yield();
    Matthew> drivers/infiniband/ulp/ipoib/ipoib_ib.c: yield();

    Matthew> *SLAP*.

ouch ;)

What should those uses of yield() be replaced with?  The loops are
polling for pending work to finish up on an exit path, and don't have
any strict timing requirements.  cond_resched() seems a bit
heavyweight, since we don't need to run for our whole time slice.  We
could do msleep(0) or msleep(1) but I don't quite see why that's much
of an improvement.

Thanks,
  Roland

--===============039054443850304876==
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

--===============039054443850304876==--