All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <roland@topspin.com>
To: Lee Revell <rlrevell@joe-job.com>
Cc: Dave Hansen <haveblue@us.ibm.com>, Josh Aas <josha@sgi.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	steiner@sgi.com
Subject: Re: bkl cleanup in do_sysctl
Date: Tue, 10 Aug 2004 12:16:08 -0700	[thread overview]
Message-ID: <52n0126byf.fsf@topspin.com> (raw)
In-Reply-To: <1092163919.782.54.camel@mindpipe> (Lee Revell's message of "Tue, 10 Aug 2004 14:51:59 -0400")

    Lee> Someone once suggested that newbies who show up on LKML
    Lee> wanting to learn kernel hacking should be assigned to find
    Lee> one use of the BKL and replace it with proper locking.

Unfortunately most of the remaining BKL uses seem to be very subtle.
Removing lock_kernel() correctly requires a deep understanding of the
global locking semantics and may be very invasive.  In the end it's
also hard to be sure bugs haven't been introduced.

    Lee> For example reiserfs uses the BKL for all write locking (!),
    Lee> but it probably would not be too hard to fix, because you can
    Lee> just look at another filesystem that has proper locking.

Fixing up a filesystem's write locking doesn't sound like a very good
newbie project to me.

 - R.

  reply	other threads:[~2004-08-10 19:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-10 16:58 bkl cleanup in do_sysctl Josh Aas
2004-08-10 17:28 ` Dave Hansen
2004-08-10 18:51   ` Lee Revell
2004-08-10 19:16     ` Roland Dreier [this message]
2004-08-10 19:21       ` Lee Revell
2004-08-10 19:46     ` Hans Reiser
2004-08-10 20:10       ` Lee Revell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52n0126byf.fsf@topspin.com \
    --to=roland@topspin.com \
    --cc=haveblue@us.ibm.com \
    --cc=josha@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rlrevell@joe-job.com \
    --cc=steiner@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.