All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rolandd@cisco.com>
To: Greg KH <gregkh@suse.de>
Cc: Jeff Garzik <jgarzik@pobox.com>, linux-kernel@vger.kernel.org
Subject: Re: What is struct pci_driver.owner for?
Date: Tue, 18 Oct 2005 14:06:26 -0700	[thread overview]
Message-ID: <52oe5mmt65.fsf@cisco.com> (raw)
In-Reply-To: <20051018205908.GA32435@suse.de> (Greg KH's message of "Tue, 18 Oct 2005 13:59:08 -0700")

    Greg> But what it really does today is create the symlink from the
    Greg> driver to the module that is contained in it, in sysfs.
    Greg> Which is very invaluable for people who want to know these
    Greg> things (installer programs, etc.)

    Greg> That "module" symlink is created only if the .owner field is
    Greg> set.  That's why people are going through and adding it to
    Greg> all of the drivers in the system.

OK, I'll make my own small contribution and push this for 2.6.15:

diff --git a/drivers/infiniband/hw/mthca/mthca_main.c b/drivers/infiniband/hw/mthca/mthca_main.c
--- a/drivers/infiniband/hw/mthca/mthca_main.c
+++ b/drivers/infiniband/hw/mthca/mthca_main.c
@@ -1196,6 +1196,7 @@ MODULE_DEVICE_TABLE(pci, mthca_pci_table
 
 static struct pci_driver mthca_driver = {
 	.name		= DRV_NAME,
+	.owner		= THIS_MODULE,
 	.id_table	= mthca_pci_table,
 	.probe		= mthca_init_one,
 	.remove		= __devexit_p(mthca_remove_one)

  parent reply	other threads:[~2005-10-18 21:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-18 20:47 What is struct pci_driver.owner for? Roland Dreier
2005-10-18 20:53 ` Jeff Garzik
2005-10-18 20:59   ` Greg KH
2005-10-18 21:04     ` Russell King
2005-10-18 21:06     ` Roland Dreier [this message]
2005-10-19 15:42       ` Jiri Slaby
2005-10-19 16:48         ` Roland Dreier
2005-10-19 16:51           ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52oe5mmt65.fsf@cisco.com \
    --to=rolandd@cisco.com \
    --cc=gregkh@suse.de \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.