From: Roland Dreier <rolandd@cisco.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Laurent riffard <laurent.riffard@free.fr>,
linux-kernel@vger.kernel.org, Greg KH <greg@kroah.com>,
Russell King <rmk+lkml@arm.linux.org.uk>
Subject: Re: [RFC patch 2/3] remove pci_driver.owner and .name fields
Date: Wed, 26 Oct 2005 14:30:59 -0700 [thread overview]
Message-ID: <52r7a8ynho.fsf@cisco.com> (raw)
In-Reply-To: <20051026212127.GU7992@ftp.linux.org.uk> (Al Viro's message of "Wed, 26 Oct 2005 22:21:27 +0100")
> It looks stupid in the first place - what's wrong with
> .driver.name = "DAC960",
> instead of that mess?
Unfortunately I don't think gcc 2.95 accepts that syntax. For
example the following:
void foo(void)
{
struct {
struct {
int y;
} x;
} bar = {
.x.y = 1
};
}
gives
a.c: In function `foo':
a.c:8: unknown field `y' specified in initializer
when compiled with gcc 2.95.
I guess we could do
.driver = { .name = "DAC960" },
but that seems silly as well.
- R.
next prev parent reply other threads:[~2005-10-26 21:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-26 20:48 [RFC patch 0/3] remove pci_driver.owner and .name fields Laurent riffard
2005-10-26 20:48 ` [RFC patch 1/3] " Laurent riffard
2005-10-26 21:20 ` Al Viro
2005-10-26 22:53 ` Laurent Riffard
2005-10-26 20:48 ` [RFC patch 2/3] " Laurent riffard
2005-10-26 21:05 ` Roland Dreier
2005-10-26 21:21 ` Al Viro
2005-10-26 21:30 ` Roland Dreier [this message]
2005-10-26 21:35 ` Andrew Morton
2005-10-26 20:48 ` [RFC patch 3/3] " Laurent riffard
2005-10-26 21:11 ` Greg KH
2005-10-26 22:22 ` Laurent Riffard
2005-10-26 22:26 ` Greg KH
2005-10-26 22:57 ` Laurent Riffard
2005-10-26 21:17 ` [RFC patch 0/3] " Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52r7a8ynho.fsf@cisco.com \
--to=rolandd@cisco.com \
--cc=greg@kroah.com \
--cc=laurent.riffard@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.