All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <roland@topspin.com>
To: Ricardo Scop <scop@digitel.com.br>
Cc: Owen Green <owenjinggreen@yahoo.com>,
	linuxppc-embedded@lists.linuxppc.org
Subject: Re: Fast HDLC driver
Date: 20 Nov 2002 09:41:59 -0800	[thread overview]
Message-ID: <52r8dg9lzs.fsf@topspin.com> (raw)
In-Reply-To: <200211201439.45731.scop@digitel.com.br>


>>>>> "Ricardo" == Ricardo Scop <scop@digitel.com.br> writes:

    Roland> I don't have a specific answer about HDLC, but I think
    Roland> calling netif_rx() from interrupt context is correct.
    Roland> netif_rx() doesn't do anything except queue the packet for
    Roland> processing and then mark the network softirq.  In fact if
    Roland> you want to call netif_rx() from non-interrupt context
    Roland> then you have to use the netif_rx_ni() function to make
    Roland> sure the softirq runs soon enough.

    Ricardo> Hmm, is this true? QSLinux driver calls netif_rx() from
    Ricardo> thew interrupts bottom half; it it ok?

This should probably be OK.  First, a bottom half is still interrupt
context.  Second, if I recall correctly, Linux 2.2 does not even
define netif_rx_ni().  If the driver works well there's no reason to
change it.

Best,
  Roland


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

  parent reply	other threads:[~2002-11-20 17:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20021119161020.83422.qmail@web20104.mail.yahoo.com>
2002-11-19 16:48 ` Fast HDLC driver Joakim Tjernlund
2002-12-17 12:44   ` memory management bug?? Owen Green
2002-11-19 16:55 ` Fast HDLC driver Roland Dreier
     [not found]   ` <200211201439.45731.scop@digitel.com.br>
2002-11-20 17:41     ` Roland Dreier [this message]
     [not found] <200211191615.gAJGFVw09351@hofr.at>
2002-11-19 19:01 ` Owen Green
2002-11-19 16:08 Owen Green

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52r8dg9lzs.fsf@topspin.com \
    --to=roland@topspin.com \
    --cc=linuxppc-embedded@lists.linuxppc.org \
    --cc=owenjinggreen@yahoo.com \
    --cc=scop@digitel.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.