From: Roland Dreier <rolandd@cisco.com>
To: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Cc: Al Viro <viro@www.linux.org.uk>,
torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] (11/43) Kconfig fix (infiniband and PCI)
Date: Wed, 24 Aug 2005 10:02:05 -0700 [thread overview]
Message-ID: <52u0hfz2sy.fsf@cisco.com> (raw)
In-Reply-To: <20050824164133.GL9322@parcelfarce.linux.theplanet.co.uk> (Al Viro's message of "Wed, 24 Aug 2005 17:41:33 +0100")
Al> PS: note that it's not depends on PCI it's depends on PCI ||
Al> BROKEN which a) documents that something is wrong b) leaves
Al> all setups usable now intact c) prevents broken setups from
Al> being picked.
Yes, I agree that this makes sense for now.
Al> I certainly agree that proper fix is to switch to dma_... - no
Al> arguments here. BTW, another dubious thing is use of
Al> DECLARE_PCI_UNMAP_ADDR() in infiniband core - it's fine in PCI
Al> drivers (which is how it's used elsewhere), but not in generic
Al> data structures.
Yes, I guess we want DECLARE_DMA_UNMAP_ADDR() as well. If I can
untangle the maze of .h files well enough to see where
dma_unmap_addr() et al. belong, I'll post a patch adding them.
- R.
prev parent reply other threads:[~2005-08-24 17:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-23 21:45 [PATCH] (11/43) Kconfig fix (infiniband and PCI) Al Viro
2005-08-24 11:26 ` Adrian Bunk
2005-08-24 14:57 ` Al Viro
2005-08-24 15:26 ` Adrian Bunk
2005-08-24 15:35 ` Al Viro
2005-08-24 16:22 ` Roland Dreier
2005-08-24 16:31 ` Al Viro
2005-08-24 16:41 ` Al Viro
2005-08-24 17:02 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52u0hfz2sy.fsf@cisco.com \
--to=rolandd@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
--cc=viro@www.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.