From: Roland Dreier <roland@topspin.com>
To: viro@parcelfarce.linux.theplanet.co.uk, torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] fix include order in mthca_memfree.c
Date: Sun, 24 Apr 2005 19:31:18 -0700 [thread overview]
Message-ID: <52vf6bwps9.fsf@topspin.com> (raw)
About commit fdca124a1bcc7e624f6b887c6f26153f40ee43ee ("missing
include in mthca"):
- Out of curiousity, what arch and/or config requires <linux/mm.h>?
I regularly cross-compile drivers/infiniband for i386, x86_64, ppc64,
ia64, sparc64 and ppc, and I haven't needed <linux/mm.h> in mthca_memfree.c.
- When making changes to drivers/infiniband, can you please cc the
maintainers or at least a public mailing list? As far as I can
tell, the patch went directly to Linus with no public review, which
doesn't seem appropriate, no matter how trivial the change.
- When adding includes, please match the existing style and put
<linux/xxx.h> includes before any local "yyy.h" includes.
Linus, please apply the patch below to move the include where it belongs.
Thanks,
Roland
Fix order of #include lines in mthca_memfree.c
Signed-off-by: Roland Dreier <roland@topspin.com>
--- linux.orig/drivers/infiniband/hw/mthca/mthca_memfree.c 2005-04-24 19:18:29.000000000 -0700
+++ linux/drivers/infiniband/hw/mthca/mthca_memfree.c 2005-04-24 19:20:10.000000000 -0700
@@ -32,10 +32,11 @@
* $Id$
*/
+#include <linux/mm.h>
+
#include "mthca_memfree.h"
#include "mthca_dev.h"
#include "mthca_cmd.h"
-#include <linux/mm.h>
/*
* We allocate in as big chunks as we can, up to a maximum of 256 KB
next reply other threads:[~2005-04-25 2:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-25 2:31 Roland Dreier [this message]
2005-04-25 4:04 ` [PATCH] fix include order in mthca_memfree.c Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52vf6bwps9.fsf@topspin.com \
--to=roland@topspin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.