From: "H. Peter Anvin" <hpa@zytor.com>
To: Stefani Seibold <stefani@seibold.net>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
x86@kernel.org, tglx@linutronix.de, mingo@redhat.com,
ak@linux.intel.com, aarcange@redhat.com, john.stultz@linaro.org,
luto@amacapital.net, xemul@parallels.com, gorcunov@openvz.org,
andriy.shevchenko@linux.intel.com
Cc: Martin.Runge@rohde-schwarz.com, Andreas.Brief@rohde-schwarz.com
Subject: Re: [PATCH v17 0/10] Add 32 bit VDSO time function support
Date: Sat, 15 Feb 2014 20:14:59 -0800 [thread overview]
Message-ID: <53003B43.4080909@zytor.com> (raw)
In-Reply-To: <1392481976-6370-1-git-send-email-stefani@seibold.net>
On 02/15/2014 08:32 AM, Stefani Seibold wrote:
> This patch add the functions vdso_gettimeofday(), vdso_clock_gettime()
> and vdso_time() to the 32 bit VDSO.
x86-64 allyesconfig:
AS arch/x86/vdso/vdso32/int80.o
/home/hpa/kernel/distwork/arch/x86/vdso/vdso32/../vclock_gettime.c:128:4: warning:
symbol 'hpet_page' was not declared
. Should it be static?
/home/hpa/kernel/distwork/arch/x86/vdso/vdso32/../vclock_gettime.c:134:33:
warning: incorrect type in argument 1 (diff
erent address spaces)
/home/hpa/kernel/distwork/arch/x86/vdso/vdso32/../vclock_gettime.c:134:33:
expected void const volatile [noderef] <
asn:2>*addr
/home/hpa/kernel/distwork/arch/x86/vdso/vdso32/../vclock_gettime.c:134:33:
got unsigned char [toplevel] *
/home/hpa/kernel/distwork/arch/x86/vdso/vdso32/../vclock_gettime.c:294:13:
warning: symbol '__vdso_clock_gettime' was
not declared. Should it be static?
/home/hpa/kernel/distwork/arch/x86/vdso/vdso32/../vclock_gettime.c:322:13:
warning: symbol '__vdso_gettimeofday' was n
ot declared. Should it be static?
/home/hpa/kernel/distwork/arch/x86/vdso/vdso32/../vclock_gettime.c:343:16:
warning: symbol '__vdso_time' was not decla
red. Should it be static?
CC arch/x86/vdso/vdso32/vclock_gettime.o
/home/hpa/kernel/distwork/arch/x86/vdso/vdso32/vclock_gettime.c:1:0:
sorry, unimplemented: -mfentry isn’t supported fo
r 32-bit in combination with -fpic
#define BUILD_VDSO32
^
make[4]: *** [arch/x86/vdso/vdso32/vclock_gettime.o] Error 1
My patience is wearing really thin. If I get another patchset that
doesn't compile in allyesconfig, allmodconfig, allnoconfig and defconfig
on both i386 and x86-64, I will put this patchset at the very bottom of
my priority list.
I strongly suggest also installing sparse and compiling with C=1 and
fixing all *those* warnings.
Sorry.
-hpa
next prev parent reply other threads:[~2014-02-16 4:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 16:32 [PATCH v17 0/10] Add 32 bit VDSO time function support Stefani Seibold
2014-02-15 16:32 ` [PATCH v17 01/10] Make vsyscall_gtod_data handling x86 generic Stefani Seibold
2014-02-15 16:32 ` [PATCH v17 02/10] Add new func _install_special_mapping() to mmap.c Stefani Seibold
2014-02-15 16:32 ` [PATCH v17 03/10] revamp vclock_gettime.c Stefani Seibold
2014-02-15 16:32 ` [PATCH v17 04/10] vclock_gettime.c __vdso_clock_gettime cleanup Stefani Seibold
2014-02-15 16:32 ` [PATCH v17 05/10] replace VVAR(vsyscall_gtod_data) by gtod macro Stefani Seibold
2014-02-15 16:32 ` [PATCH v17 06/10] cleanup __vdso_gettimeofday Stefani Seibold
2014-02-15 16:32 ` [PATCH v17 07/10] introduce VVAR marco for vdso32 Stefani Seibold
2014-02-15 16:32 ` [PATCH v17 08/10] Add 32 bit VDSO time support for 32 bit kernel Stefani Seibold
2014-02-15 16:32 ` [PATCH v17 09/10] Add 32 bit VDSO time support for 64 " Stefani Seibold
2014-02-16 4:14 ` H. Peter Anvin [this message]
2014-02-16 7:13 ` [PATCH v17 0/10] Add 32 bit VDSO time function support Stefani Seibold
2014-02-16 8:29 ` Stefani Seibold
2014-02-16 16:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53003B43.4080909@zytor.com \
--to=hpa@zytor.com \
--cc=Andreas.Brief@rohde-schwarz.com \
--cc=Martin.Runge@rohde-schwarz.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gorcunov@openvz.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=stefani@seibold.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.