All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 5/5] tcg/i386: Use SHLX/SHRX/SARX instructions
Date: Sun, 16 Feb 2014 15:21:28 +0100	[thread overview]
Message-ID: <5300C968.9040609@redhat.com> (raw)
In-Reply-To: <1391179418-13422-6-git-send-email-rth@twiddle.net>

Il 31/01/2014 15:43, Richard Henderson ha scritto:
> +    gen_shift_maybe_vex:
> +        if (have_bmi2 && !const_args[2]) {
> +            tcg_out_vex_modrm(s, vexop + rexw, args[0], args[2], args[1]);
> +            break;
> +        }
> +        /* FALLTHRU */

What if args[2] happens to be ECX?

Apart from this,

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

so feel free to post PATCH 6/5 and then squash it in the pull request.

Paolo

  reply	other threads:[~2014-02-16 14:21 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-31 14:43 [Qemu-devel] [PATCH 0/5] tcg/i386 support for bmi Richard Henderson
2014-01-31 14:43 ` [Qemu-devel] [PATCH 1/5] disas/i386: Disassemble ANDN/SHLX/SHRX/SHAX Richard Henderson
2014-02-16 18:12   ` Aurelien Jarno
2014-01-31 14:43 ` [Qemu-devel] [PATCH 2/5] tcg/i386: Move TCG_CT_CONST_* to tcg-target.c Richard Henderson
2014-02-16 18:12   ` Aurelien Jarno
2014-01-31 14:43 ` [Qemu-devel] [PATCH 3/5] tcg/i386: Add tcg_out_vex_modrm Richard Henderson
2014-02-16 18:12   ` Aurelien Jarno
2014-01-31 14:43 ` [Qemu-devel] [PATCH 4/5] tcg/i386: Use ANDN instruction Richard Henderson
2014-02-16 18:12   ` Aurelien Jarno
2014-02-17 16:18     ` Richard Henderson
2014-02-20 16:25   ` Peter Maydell
2014-02-20 16:42     ` Peter Maydell
2014-02-20 16:43     ` Richard Henderson
2014-02-20 17:38       ` Peter Maydell
2014-01-31 14:43 ` [Qemu-devel] [PATCH 5/5] tcg/i386: Use SHLX/SHRX/SARX instructions Richard Henderson
2014-02-16 14:21   ` Paolo Bonzini [this message]
2014-02-16 17:57     ` Richard Henderson
2014-02-17 16:01     ` Richard Henderson
2014-02-16 18:12   ` Aurelien Jarno
2014-02-14 21:44 ` [Qemu-devel] [PATCH 0/5] tcg/i386 support for bmi Richard Henderson
2014-02-16 14:22   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5300C968.9040609@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.