All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Bergmann <frank@frajasalo.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] crda: fix build failure for nios2
Date: Sun, 16 Feb 2014 23:16:34 +0100	[thread overview]
Message-ID: <530138C2.7010109@frajasalo.de> (raw)

libgcrypt depends on libgpg-error and this isn't accounted for in
crda makefile, but it is in libgcrypt-config script (in the correct
order for linking), so set LDLIBS calling this script not only for
static linking.

Fixes http://autobuild.buildroot.org/results/156/15656ef0187b0a8db6c66fc7a7fcb58a99999fa1

Signed-off-by: Frank Bergmann <frank@frajasalo.de>
---
  package/crda/crda.mk |    6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/crda/crda.mk b/package/crda/crda.mk
index ce87d44..c7e9b2d 100644
--- a/package/crda/crda.mk
+++ b/package/crda/crda.mk
@@ -16,12 +16,12 @@ CRDA_LICENSE_FILES = LICENSE
  # And library order matters hence stick -lnl-3 first since it's appended
  # in the crda Makefiles as in NLLIBS+=-lnl-3 ... thus failing.
  #
-# libgcrypt needs -lgpg-error if linking statically, which is correctly
-# set by the libgcrypt-config script (and in the right order).
  ifeq ($(BR2_PREFER_STATIC_LIB),y)
  CRDA_NLLIBS += -lnl-3 -lm -lpthread
-CRDA_LDLIBS += `$(STAGING_DIR)/usr/bin/libgcrypt-config --libs`
  endif
+# libgcrypt needs -lgpg-error, which is correctly
+# set by the libgcrypt-config script (and in the right order).
+CRDA_LDLIBS += `$(STAGING_DIR)/usr/bin/libgcrypt-config --libs`

  define CRDA_BUILD_CMDS
         $(TARGET_CONFIGURE_OPTS) \
-- 
1.7.10.4

             reply	other threads:[~2014-02-16 22:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-16 22:16 Frank Bergmann [this message]
2014-02-16 22:28 ` [Buildroot] [PATCH 1/1] crda: fix build failure for nios2 Samuel Martin
2014-02-18 16:09 ` Thomas Petazzoni
2014-02-18 21:25 ` Peter Korsgaard
2014-02-18 22:20   ` Frank Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530138C2.7010109@frajasalo.de \
    --to=frank@frajasalo.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.