All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Hahler <genml+git-2014@thequod.de>
To: git@vger.kernel.org
Subject: Output from "rev-parse --resolve-git-dir" changed: two lines (prints original argument)
Date: Mon, 17 Feb 2014 09:13:40 +0100	[thread overview]
Message-ID: <5301C4B4.5070503@thequod.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

I have noticed that the output from "git rev-parse --resolve-git-dir" changed.

While it used to only print the resolved git dir, it now prints the argument passed to it itself:

    % git rev-parse --resolve-git-dir .git
    /path/to/root/.git/modules/vim/bundle/reporoot
    .git

This is with Git version 1.8.5.3, but also happens with master.

You can use "--flags" to avoid this ("git rev-parse --flags --resolve-git-dir .git"), but it is unclear from the documentation if that's the intended beahviour.

It seems like the "--resolve-git-dir" subcommand needs to consume the argument passed to it.


Regards,
Daniel.

-- 
http://daniel.hahler.de/


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 255 bytes --]

             reply	other threads:[~2014-02-17  8:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-17  8:13 Daniel Hahler [this message]
2014-02-17  8:46 ` [PATCH] rev-parse: fix --resolve-git-dir argument handling John Keeping
2014-02-18 20:42   ` Junio C Hamano
2014-02-19  0:25     ` Junio C Hamano
2014-02-19  9:09       ` John Keeping

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5301C4B4.5070503@thequod.de \
    --to=genml+git-2014@thequod.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.