From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tero Kristo Subject: Re: [PATCH 2/2] ARM: DTS: OMAP4: Add gpmc_fck clock node Date: Mon, 17 Feb 2014 14:29:45 +0200 Message-ID: <530200B9.8090407@ti.com> References: <1392636465-31459-1-git-send-email-florian.vaussard@epfl.ch> <1392636465-31459-3-git-send-email-florian.vaussard@epfl.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:59558 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751594AbaBQMaT (ORCPT ); Mon, 17 Feb 2014 07:30:19 -0500 In-Reply-To: <1392636465-31459-3-git-send-email-florian.vaussard@epfl.ch> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Florian Vaussard , =?ISO-8859-1?Q?Beno=EEt_?= =?ISO-8859-1?Q?Cousson?= , Tony Lindgren Cc: Mike Turquette , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org On 02/17/2014 01:27 PM, Florian Vaussard wrote: > Add the gpmc_fck clock, derived from l3_ick, and reference it from > the GPMC node to get it correctly working. > > Signed-off-by: Florian Vaussard > --- > arch/arm/boot/dts/omap4.dtsi | 2 ++ > arch/arm/boot/dts/omap44xx-clocks.dtsi | 6 ++++++ > 2 files changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi > index d3f8a6e..8a0cc71 100644 > --- a/arch/arm/boot/dts/omap4.dtsi > +++ b/arch/arm/boot/dts/omap4.dtsi > @@ -275,6 +275,8 @@ > gpmc,num-waitpins = <4>; > ti,hwmods = "gpmc"; > ti,no-idle-on-init; > + clocks = <&gpmc_fck>; > + clock-names = "fck"; > }; > > uart1: serial@4806a000 { > diff --git a/arch/arm/boot/dts/omap44xx-clocks.dtsi b/arch/arm/boot/dts/omap44xx-clocks.dtsi > index c821ff5..ae2c441 100644 > --- a/arch/arm/boot/dts/omap44xx-clocks.dtsi > +++ b/arch/arm/boot/dts/omap44xx-clocks.dtsi > @@ -1036,6 +1036,12 @@ > ti,index-power-of-two; > }; > > + gpmc_fck: gpmc_fck { > + #clock-cells = <0>; > + compatible = "ti,clkdm-gate-clock"; > + clocks = <&l3_div_ck>; > + }; > + Why not implement a proper gate clock for CM_L3_2_GPMC_CLKCTRL? The approach you have taken looks good to me otherwise. -Tero > gpio2_dbclk: gpio2_dbclk { > #clock-cells = <0>; > compatible = "ti,gate-clock"; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: t-kristo@ti.com (Tero Kristo) Date: Mon, 17 Feb 2014 14:29:45 +0200 Subject: [PATCH 2/2] ARM: DTS: OMAP4: Add gpmc_fck clock node In-Reply-To: <1392636465-31459-3-git-send-email-florian.vaussard@epfl.ch> References: <1392636465-31459-1-git-send-email-florian.vaussard@epfl.ch> <1392636465-31459-3-git-send-email-florian.vaussard@epfl.ch> Message-ID: <530200B9.8090407@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/17/2014 01:27 PM, Florian Vaussard wrote: > Add the gpmc_fck clock, derived from l3_ick, and reference it from > the GPMC node to get it correctly working. > > Signed-off-by: Florian Vaussard > --- > arch/arm/boot/dts/omap4.dtsi | 2 ++ > arch/arm/boot/dts/omap44xx-clocks.dtsi | 6 ++++++ > 2 files changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi > index d3f8a6e..8a0cc71 100644 > --- a/arch/arm/boot/dts/omap4.dtsi > +++ b/arch/arm/boot/dts/omap4.dtsi > @@ -275,6 +275,8 @@ > gpmc,num-waitpins = <4>; > ti,hwmods = "gpmc"; > ti,no-idle-on-init; > + clocks = <&gpmc_fck>; > + clock-names = "fck"; > }; > > uart1: serial at 4806a000 { > diff --git a/arch/arm/boot/dts/omap44xx-clocks.dtsi b/arch/arm/boot/dts/omap44xx-clocks.dtsi > index c821ff5..ae2c441 100644 > --- a/arch/arm/boot/dts/omap44xx-clocks.dtsi > +++ b/arch/arm/boot/dts/omap44xx-clocks.dtsi > @@ -1036,6 +1036,12 @@ > ti,index-power-of-two; > }; > > + gpmc_fck: gpmc_fck { > + #clock-cells = <0>; > + compatible = "ti,clkdm-gate-clock"; > + clocks = <&l3_div_ck>; > + }; > + Why not implement a proper gate clock for CM_L3_2_GPMC_CLKCTRL? The approach you have taken looks good to me otherwise. -Tero > gpio2_dbclk: gpio2_dbclk { > #clock-cells = <0>; > compatible = "ti,gate-clock"; >