From: Steven Barth <cyrus@openwrt.org>
To: netdev@vger.kernel.org
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
Subject: Re: [PATCH v2] ipv6: fix inconsistent prefix route handling
Date: Mon, 17 Feb 2014 15:23:34 +0100 [thread overview]
Message-ID: <53021B66.3000101@openwrt.org> (raw)
In-Reply-To: <20140217140826.GD22833@order.stressinduktion.org>
On 17.02.2014 15:08, Hannes Frederic Sowa wrote:
>
> I fear there is currently no combination of ifp->flags which can test for
> that. Your first patch seems to be too dangerous in removing neighbour
> discovery brought in on-link state, I fear. It may even be a problem for
> permanent ones, but that's how it is done, currently.
Yeah the kernel neighbor discovery support is a bit tricky in itself and
I found myself working around it more often then actually using it (at
least when doing router-stuff).
>
> Best option would be to fully decouple prefix routes from address handling,
> but that would break current userspace.
>
> Current iproute has support for no-prefix-route address addition (see
> iproute2 commit 58c69b226fb3a ("add support for IFA_F_NOPREFIXROUTE")), so you
> could manage those address and route combination directly from user space.
OK, I will use a workaround for now that removes and readds addresses
when they should be deprecated instead of just converting permanents to
non-permanents and maybe later use that new NOPREFIXROUTE feature which
should come in handy.
>
> So if we want to clean up those routes we either must set IFA_F_PERMANENT to
> the ifp flags of the address in inet6_addr_add and really make sure nothing
> breaks because of this. Or introduce a new flag, like IFA_F_USERINSTALLED e.g.
OK, I will try to think about this when I have some more time to spare
on this.
Thanks for your help so far.
Steven
prev parent reply other threads:[~2014-02-17 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 15:48 [PATCH] ipv6: fix inconsistent prefix route handling Steven Barth
2014-02-16 16:25 ` [PATCH v2] " Steven Barth
2014-02-16 16:51 ` Hannes Frederic Sowa
2014-02-17 6:41 ` Steven Barth
2014-02-17 13:05 ` Hannes Frederic Sowa
2014-02-17 13:13 ` Steven Barth
2014-02-17 14:08 ` Hannes Frederic Sowa
2014-02-17 14:23 ` Steven Barth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53021B66.3000101@openwrt.org \
--to=cyrus@openwrt.org \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.