All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Andreas Faerber <afaerber@suse.de>,
	Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure
Date: Mon, 17 Feb 2014 17:16:48 +0100	[thread overview]
Message-ID: <530235F0.2040406@redhat.com> (raw)
In-Reply-To: <1392651898-16749-4-git-send-email-stefanha@redhat.com>

Il 17/02/2014 16:44, Stefan Hajnoczi ha scritto:
>  }
>
> +static void sigabrt_handler(int signo)
> +{
> +    qtest_end();
> +}
> +

void qtest_quit(QTestState *s)
{
     int status;

     if (s->qemu_pid != -1) {
         kill(s->qemu_pid, SIGTERM);
         waitpid(s->qemu_pid, &status, 0);
     }

     close(s->fd);
     close(s->qmp_fd);
     g_string_free(s->rx, true);
     g_free(s);
}

Not async-signal safe.  You need to ignore the g_string_free and g_free 
(perhaps even the closes) if calling from the sigabrt_handler.

Paolo

  reply	other threads:[~2014-02-17 16:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-17 15:44 [Qemu-devel] [PATCH 0/3] qtest: avoid pidfile and QEMU process leaks Stefan Hajnoczi
2014-02-17 15:44 ` [Qemu-devel] [PATCH 1/3] qtest: drop unused child_pid field Stefan Hajnoczi
2014-02-17 15:44 ` [Qemu-devel] [PATCH 2/3] qtest: make QEMU our direct child process Stefan Hajnoczi
2014-02-17 16:44   ` Markus Armbruster
2014-02-18  9:00     ` Stefan Hajnoczi
2014-02-18  9:53       ` Markus Armbruster
2014-02-17 15:44 ` [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure Stefan Hajnoczi
2014-02-17 16:16   ` Paolo Bonzini [this message]
2014-02-17 17:00     ` Markus Armbruster
2014-02-18  9:05       ` Stefan Hajnoczi
2014-02-18 10:05         ` Markus Armbruster
2014-02-18 10:23           ` Paolo Bonzini
2014-02-18 10:43             ` Markus Armbruster
2014-02-18 14:38               ` Stefan Hajnoczi
2014-02-18 10:07         ` Paolo Bonzini
2014-02-18 10:17           ` Daniel P. Berrange
2014-02-18 10:23             ` Paolo Bonzini
2014-02-17 16:49   ` Markus Armbruster
2014-02-17 16:56     ` Paolo Bonzini
2014-02-18  9:17     ` Stefan Hajnoczi
2014-02-18  9:55       ` Markus Armbruster
2014-02-18 14:44         ` Stefan Hajnoczi
2014-02-18 14:56       ` Peter Maydell
2014-02-18 10:02     ` Markus Armbruster
2014-02-18 14:38       ` Stefan Hajnoczi
2014-02-18 14:52         ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530235F0.2040406@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@amazon.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.