From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58750)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WFWzD-00058J-A4
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 17:48:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WFWz4-0004fj-U9
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 17:48:27 -0500
Received: from mail-qc0-x234.google.com ([2607:f8b0:400d:c01::234]:49098)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WFWz4-0004fe-Px
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 17:48:18 -0500
Received: by mail-qc0-f180.google.com with SMTP id i17so24357316qcy.25
	for <qemu-devel@nongnu.org>; Mon, 17 Feb 2014 14:48:18 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <530238E9.4010107@twiddle.net>
Date: Mon, 17 Feb 2014 10:29:29 -0600
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1392574872-28725-1-git-send-email-peter.maydell@linaro.org>
	<1392574872-28725-6-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1392574872-28725-6-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/6] target-arm: A64: Implement PMULL
	instruction
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, patches@linaro.org, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 02/16/2014 12:21 PM, Peter Maydell wrote:
> +/* Helper function for 64 bit polynomial multiply case:
> + * perform PolynomialMult(op1, op2) and return either the top or
> + * bottom half of the 128 bit result.
> + */
> +uint64_t HELPER(neon_pmull_64_lo)(CPUARMState *env, uint64_t op1, uint64_t op2)
> +{
> +    int bitnum;
> +    uint64_t res = 0;
> +
> +    for (bitnum = 0; bitnum < 64; bitnum++) {
> +        if (op1 & (1ULL << bitnum)) {
> +            res ^= op2 << bitnum;
> +        }
> +    }
> +    return res;
> +}

These functions don't use env.  Why are you passing it?

r~