Re: [Qemu-devel] [PATCH v8 14/17] Add the vhost-user netdev backend to the command line

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]

On 02/13/2014 05:03 AM, Antonios Motakis wrote:
> The supplied chardev id will be inspected for supported options. Only
> a socket backend, with a set path (i.e. a Unix socket) and optionally
> the server parameter set, will be allowed. Other options (nowait, telnet)
> will make the chardev unusable and the netdev will not be initialised.
> 
> Additional checks for validity:
>   - requires `-mempath ...,share=on`
>   - requires `-device virtio-net-*`
> 
> The `vhostforce` option is uset to force vhost-net when we deal with no-MSIX
> guest.
> 
> Signed-off-by: Antonios Motakis <a.motakis@virtualopensystems.com>
> Signed-off-by: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>
> ---

QMP review only:


> +++ b/qapi-schema.json
> @@ -3104,6 +3104,22 @@
>      '*devname':    'str' } }
>  
>  ##
> +# @NetdevVhostUserOptions
> +#
> +# Vhost-user network backend
> +#
> +# @path: control socket path
> +#
> +# @vhostforce: #optional vhost on for non-MSIX virtio guests

What's the default value when this is omitted?

> +#
> +# Since 2.0
> +##
> +{ 'type': 'NetdevVhostUserOptions',
> +  'data': {
> +    'chardev':		'str',
> +    '*vhostforce':	'bool' } }

Kill the TABs.  The rest of this file uses spaces.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]