From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54856)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WFWiD-0008Oq-LN
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 17:30:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WFWi9-0007x4-7w
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 17:30:53 -0500
Received: from mx1.redhat.com ([209.132.183.28]:2821)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WFWi8-0007wy-N1
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 17:30:49 -0500
Message-ID: <53028D8A.5060500@redhat.com>
Date: Mon, 17 Feb 2014 15:30:34 -0700
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1392675899-21210-1-git-send-email-afaerber@suse.de>
	<1392675899-21210-47-git-send-email-afaerber@suse.de>
In-Reply-To: <1392675899-21210-47-git-send-email-afaerber@suse.de>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="fJRXvN1ixjoNKiSN5Mtpiwgcxr2SquTXO"
Subject: Re: [Qemu-devel] [PULL v2 46/49] qdev: Add enum property types to
	QAPI schema
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, Markus Armbruster <armbru@redhat.com>, Anthony Liguori <aliguori@amazon.com>, "Michael S. Tsirkin" <mst@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--fJRXvN1ixjoNKiSN5Mtpiwgcxr2SquTXO
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 02/17/2014 03:24 PM, Andreas F=C3=A4rber wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
>=20
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
> ---

> +++ b/qapi-schema.json
> @@ -28,7 +28,65 @@
>    'data': [ 'GenericError', 'CommandNotFound', 'DeviceEncrypted',
>              'DeviceNotActive', 'DeviceNotFound', 'KVMMissingCap' ] }
> =20
> +
> +##
> +# LostTickPolicy:

=2E..

> +
>  ##
> +# BiosAtaTranslation:
> +#

=2E..

> +
>  # @add_client

Oops - we lost the ## header before add_client.  Sounds like a followup
patch might be called for, unless you are okay tweaking the pull request.=


--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--fJRXvN1ixjoNKiSN5Mtpiwgcxr2SquTXO
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJTAo2KAAoJEKeha0olJ0NqEQQH/1OjW4n0ixmzRrk2fRk/iRU3
4Udu7S0iEP3Cw26h1YeXfZ/Ymi4lXNv5Azm6sKbHvs/hhEHTq4ZFqr6rJd0zrfVg
1QNioOgp8bweAfbZrqs35ViehvvqnBY6EJkmE3mbctL1Njqa9iCbdAva8zxYewvg
C120j9UoWD84ZtNFfbbtLDOZxKux2n11JaElH4i3QDR9pCtHQ4HEdMrdFIpoFEFi
O6LkgtP40/kPALipB3+JzOiK+tNw6k+Da63Me0ow70IoM33Z+Qwxds227u+LGssN
DQQUzJKYIevirl7lWtZKlo1QvDseXB9PahdPHwipVfRZf26yDnQ3SK2Ep8wzjtQ=
=78Ei
-----END PGP SIGNATURE-----

--fJRXvN1ixjoNKiSN5Mtpiwgcxr2SquTXO--