From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Fabio Estevam <festevam@gmail.com>, tj@kernel.org
Cc: linux-ide@vger.kernel.org, Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH v2 1/2] pata_imx: Use devm_ioremap_resource() to simplify code
Date: Tue, 18 Feb 2014 02:12:32 +0300 [thread overview]
Message-ID: <53029760.9050407@cogentembedded.com> (raw)
In-Reply-To: <1392674757-1788-1-git-send-email-festevam@gmail.com>
On 02/18/2014 01:05 AM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> Using devm_ioremap_resource() can lead to code simplication, as we don't need
> to explicitily check for error returned by platform_get_resource().
> Also, no need to print an error message when devm_ioremap_resource() fails,
> as the OOM code code will shout loudly on such condition.
Not only OOM code, the function itself will cuss loudly too. :-)
WBR, Sergei
next prev parent reply other threads:[~2014-02-17 22:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 22:05 [PATCH v2 1/2] pata_imx: Use devm_ioremap_resource() to simplify code Fabio Estevam
2014-02-17 22:05 ` [PATCH v2 2/2] pata_imx: Propagate the real error code on platform_get_irq() failure Fabio Estevam
2014-02-17 23:12 ` Sergei Shtylyov [this message]
2014-02-18 22:41 ` [PATCH v2 1/2] pata_imx: Use devm_ioremap_resource() to simplify code Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53029760.9050407@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.