From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wang Weidong Subject: Re: [PATCH] ethtool: check the ethtool_ops is NULL in dev_ethtool Date: Tue, 18 Feb 2014 09:20:58 +0800 Message-ID: <5302B57A.1040806@huawei.com> References: <5301F32C.4040704@huawei.com> <53024266.8010700@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: David Miller , To: Daniel Borkmann Return-path: Received: from szxga02-in.huawei.com ([119.145.14.65]:55902 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbaBRBVP (ORCPT ); Mon, 17 Feb 2014 20:21:15 -0500 In-Reply-To: <53024266.8010700@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On 2014/2/18 1:09, Daniel Borkmann wrote: > On 02/17/2014 12:31 PM, Wang Weidong wrote: >> some drivers maybe not implement the ethtool_ops with only >> set NULL. So when call the ethtool cmds will lead to a >> 'NULL pointer dereference'. >> >> So add a checking in dev_ethtool. >> >> Signed-off-by: Wang Weidong >> --- >> net/core/ethtool.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/net/core/ethtool.c b/net/core/ethtool.c >> index 30071de..f418dcb 100644 >> --- a/net/core/ethtool.c >> +++ b/net/core/ethtool.c >> @@ -1499,6 +1499,9 @@ int dev_ethtool(struct net *net, struct ifreq *ifr) >> if (!ns_capable(net->user_ns, CAP_NET_ADMIN)) >> return -EPERM; >> } >> + > > You have a trailing whitespace/tab in the line above. Please > use checkpatch for detecting such things. > Sorry for that. I will fix it soon. > Can you be more specific with "some drivers"? Any driver that > is in the mainline tree? > No. My team implements a driver without considering the ethtool_ops. So I got the problem. >> + if (!dev->ethtool_ops) >> + return -EOPNOTSUPP; >> >> if (dev->ethtool_ops->begin) { >> rc = dev->ethtool_ops->begin(dev); >> > >