Re: [Qemu-devel] [Qemu-stable] [PATCH] rdma: memory leak InetSocketAddress

["Michael R. Hines" <mrhines@linux.vnet.ibm.com>]

On 02/16/2014 10:33 AM, Michael Roth wrote:
> Quoting Frank (2013-09-12 08:51:56)
>> It is allocated by g_new0() in inet_parse(), so needs to be freed in qemu_rdma_data_init().
>>
>>  From d7a8d1aad11fbe9af389cf9dd6cee14cc3249b1f Mon Sep 17 00:00:00 2001
>> From: Frank Yang <frank.yangjie@gmail.com>
>> Date: Thu, 12 Sep 2013 21:37:56 +0800
>> Subject: [PATCH] rdma: memory leak InetSocketAddress
>>
>> Signed-off-by: Frank Yang <frank.yangjie@gmail.com>
> Ping, looking to pull this in for 1.7.1

Actually, this fix is not fully correct. Let me re-send.

- Michael

>> ---
>>   migration-rdma.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/migration-rdma.c b/migration-rdma.c
>> index 05a155b..bcbe2d2 100644
>> --- a/migration-rdma.c
>> +++ b/migration-rdma.c
>> @@ -2512,6 +2512,7 @@ static void *qemu_rdma_data_init(const char *host_port, Error **errp)
>>           }
>>       }
>>
>> +    qapi_free_InetSocketAddress(addr);
>>       return rdma;
>>   }
>>
>> -- 
>> 1.8.3.msysgit.0
>>
>> -- 
>> Frank
>