From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: Don't include extended name in shared attributes
Date: Tue, 18 Feb 2014 10:27:35 +0000 [thread overview]
Message-ID: <53033597.1010503@kernel.org> (raw)
In-Reply-To: <1392387566-8411-1-git-send-email-lars@metafoo.de>
On 14/02/14 14:19, Lars-Peter Clausen wrote:
> The extended name is channel specific and should not be included in shared
> attributes.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git
> ---
> It's a fix, but there are no drivers yet, which have channels with extended
> names and shared attributes, so no need to apply it to the fixes branch.
Thanks for making this clear - saves me checking ;)
> ---
> drivers/iio/industrialio-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index acc911a..fd96e8b 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -558,7 +558,7 @@ int __iio_device_attr_init(struct device_attribute *dev_attr,
> ->channel2],
> postfix);
> } else {
> - if (chan->extend_name == NULL)
> + if (chan->extend_name == NULL || shared_by != IIO_SEPARATE)
> full_postfix = kstrdup(postfix, GFP_KERNEL);
> else
> full_postfix = kasprintf(GFP_KERNEL,
>
prev parent reply other threads:[~2014-02-18 10:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 14:19 [PATCH 1/2] iio: Don't include extended name in shared attributes Lars-Peter Clausen
2014-02-14 14:19 ` [PATCH 2/2] iio: Avoid unnecessary kasprintf Lars-Peter Clausen
2014-02-18 10:31 ` Jonathan Cameron
2014-02-18 10:27 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53033597.1010503@kernel.org \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.