From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH] xen/arm: Save/restore GICH_VMCR on domain
	context switch
Date: Tue, 18 Feb 2014 17:13:52 +0000
Message-ID: <530394D0.1080706@eu.citrix.com>
References: <1392731901-20233-1-git-send-email-julien.grall@linaro.org>
	<1392735093.11080.81.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <George.Dunlap@citrix.com>) id 1WFoF8-0008GL-BV
	for xen-devel@lists.xenproject.org; Tue, 18 Feb 2014 17:14:04 +0000
In-Reply-To: <1392735093.11080.81.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>, Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, tim@xen.org, George Dunlap <george.dunlap@citrix.com>, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 02/18/2014 02:51 PM, Ian Campbell wrote:
> On Tue, 2014-02-18 at 13:58 +0000, Julien Grall wrote:
>> GICH_VMCR register contains alias to important bits of GICV interface such as:
>>      - priority mask of the CPU
>>      - EOImode
>>      - ...
>>
>> We were safe because Linux guest always use the same value for this bits.
>> When new guests will handle priority or change EOI mode, VCPU interrupt
>> management will be in a wrong state.
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>> Cc: George Dunlap <george.dunlap@citrix.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
>> ---
>>      This is a bug fix for Xen 4.4. Without this patch we can't support guest
>>      that doesn't have the same behavior as Linux to handle GICC interface.
>>      theses bits are not modified by them.
> I'd say we pretty much have to take this -- otherwise some guest can
> break things for everyone else by writing to GICC registers.
>
> I've had a look at the GICH register list and I think we correctly
> switch everything else.

It looks that way to me as well:

Release-acked-by: George Dunlap <george.dunlap@eu.citrix.com>