From: Arend van Spriel <arend@broadcom.com>
To: David Miller <davem@davemloft.net>,
<mathias.kretschmer@fokus.fraunhofer.de>
Cc: <sw@simonwunderlich.de>, <netdev@vger.kernel.org>,
<linux-wireless@vger.kernel.org>
Subject: Re: [net-next v2 3/3] cfg80211: add MPLS and 802.21 classification
Date: Tue, 18 Feb 2014 18:30:30 +0100 [thread overview]
Message-ID: <530398B6.2060806@broadcom.com> (raw)
In-Reply-To: <20140217.140653.1309552047403078220.davem@davemloft.net>
On 02/17/2014 08:06 PM, David Miller wrote:
> From: "Kretschmer, Mathias" <mathias.kretschmer@fokus.fraunhofer.de>
> Date: Mon, 17 Feb 2014 17:34:34 +0000
>
>> Thought so, as well. But it seems that skb->protocol is not properly
>> set when the packet originates from a packet socket. And in our
>> case we cannot set it to a fixed etherType in the bind() call since
>> we use three different etherTypes on the same socket.
>
> So many things break if the skb->protocol isn't set correctly that I
> would consider such SKBs mal-formed.
That was my take as well, but how does the kernel code consider this?
> You can specify the protocol number in the msghdr passed into the
> send.
>
Regards,
Arend
next prev parent reply other threads:[~2014-02-18 17:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 16:56 [net-next v2 0/3] 802.21 and MPLS headers and classification Simon Wunderlich
2014-02-17 16:56 ` Simon Wunderlich
2014-02-17 16:56 ` [net-next v2 1/3] if_ether.h: add IEEE 802.21 Ethertype Simon Wunderlich
2014-02-17 16:56 ` Simon Wunderlich
2014-02-17 16:56 ` [net-next v2 2/3] UAPI: add MPLS label stack definition Simon Wunderlich
2014-02-17 16:56 ` [net-next v2 3/3] cfg80211: add MPLS and 802.21 classification Simon Wunderlich
2014-02-17 17:30 ` Arend van Spriel
2014-02-17 17:30 ` Arend van Spriel
2014-02-17 17:34 ` Kretschmer, Mathias
2014-02-17 17:34 ` Kretschmer, Mathias
2014-02-17 19:06 ` David Miller
2014-02-17 19:11 ` Kretschmer, Mathias
2014-02-17 19:14 ` David Miller
2014-02-17 19:20 ` Kretschmer, Mathias
2014-02-18 17:30 ` Arend van Spriel [this message]
2014-02-17 17:57 ` Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530398B6.2060806@broadcom.com \
--to=arend@broadcom.com \
--cc=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mathias.kretschmer@fokus.fraunhofer.de \
--cc=netdev@vger.kernel.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.