From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Hellstrom <thellstrom@vmware.com>
Subject: Multiple simultaneous masters?
Date: Tue, 18 Feb 2014 21:18:02 +0100
Message-ID: <5303BFFA.3010704@vmware.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from smtp-outbound-1.vmware.com (smtp-outbound-1.vmware.com
	[208.91.2.12])
	by gabe.freedesktop.org (Postfix) with ESMTP id ACE5AFAC3A
	for <dri-devel@lists.freedesktop.org>;
	Tue, 18 Feb 2014 12:18:05 -0800 (PST)
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Cc: Dave Airlie <airlied@redhat.com>
List-Id: dri-devel@lists.freedesktop.org

It turns out that if we have two clients, one opening /dev/dri/card0 and
one opending /dev/dri/controlD64, both will attempt to become active master.

That seems a little illogical to me (and makes the vmwgfx driver BUG).
Shouldn't we have at most one active master per device, and hence
attempt to replace

file_priv->minor->master with
file_priv->minor->dev->active_master

/Thomas