From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH V6 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}() Date: Tue, 18 Feb 2014 15:26:01 -0700 Message-ID: <5303DDF9.3050806@wwwdotorg.org> References: <5303C2FC.8040508@wwwdotorg.org> <1455643.Gytp1zkkCW@vostro.rjw.lan> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1455643.Gytp1zkkCW@vostro.rjw.lan> Sender: linux-pm-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: "Rafael J. Wysocki" Cc: Viresh Kumar , linaro-kernel@lists.linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, nm@ti.com, kgene.kim@samsung.com, jinchoi@broadcom.com, tianyu.lan@intel.com, sebastian.capella@linaro.org, jhbird.choi@samsung.com On 02/18/2014 03:36 PM, Rafael J. Wysocki wrote: > On Tuesday, February 18, 2014 01:30:52 PM Stephen Warren wrote: >> On 02/17/2014 02:25 AM, Viresh Kumar wrote: >>> This patchset creates/calls cpufreq suspend/resume callbacks from dpm_{suspend|resume}() >>> for handling suspend/resume of cpufreq governors and core. >>> >>> There are multiple problems that are fixed by this patch: >>> - Nishanth Menon (TI) found an interesting problem on his platform, OMAP. His board >>> wasn't working well with suspend/resume as calls for removing non-boot CPUs >>> was turning out into a call to drivers ->target() which then tries to play >>> with regulators. But regulators and their I2C bus were already suspended and >>> this resulted in a failure. Many platforms have such problems, samsung, tegra, >>> etc.. They solved it with driver specific PM notifiers where they used to >>> disable their driver's ->target() routine. >>> - Lan Tianyu (Intel) & Jinhyuk Choi (Broadcom) found an issue where tunables >>> configuration for clusters/sockets with non-boot CPUs was getting lost after >>> suspend/resume, as we were notifying governors with CPUFREQ_GOV_POLICY_EXIT on >>> removal of the last cpu for that policy and so deallocating memory for >>> tunables. This is fixed by this patch as we don't allow any operation on >>> governors after device suspend and before device resume now. >> >> The series, >> Tested-by: Stephen Warren > > Is this series necessary to fix bugs that you're seeing in 3.14-rc and if so, > the what bugs are they? No, Viresh sent a separate patch that fixed the sysfs warning I was getting (I believe you've already applied that), and there's still some ongoing discussion about the other kernel spew.