Re: [PATCH v3 1/4] Phytec phyFLEX-i.MX6 : Added USB_OTG Support

[Ashutosh <Ashutosh.s@phytec.in>]

[-- Attachment #1: Type: text/plain, Size: 1658 bytes --]

> On Wed, Feb 19, 2014 at 10:23:09AM +0800, Shawn Guo wrote:
>>> @@ -18,6 +18,14 @@
>>>   	memory {
>>>   		reg = <0x10000000 0x80000000>;
>>>   	};
>>> +
>>> +	reg_usb_otg_vbus: regulator@0 {
>> You do not have a 'reg' property in the node, so you shouldn't have
>> '@num' in node name.  You may want to name it 'regulator-0'.
> I just saw the talk between Stephen and Mark [1], and I'm with Stephen
> that neither regulator-0 nor regulator_0 is a good name.  Since Mark is
> giving up the argument on the container, please follow the way we do in
> other IMX dts today.
>
> Shawn
>
> [1] http://thread.gmane.org/gmane.linux.drivers.devicetree/61894/focus=62405
>
By seeing the discussion would the below changes is appropriate

regulators {
                 compatible = "simple-bus";
                 #address-cells = <1>;
                 #size-cells = <0>;

                 reg_usb_otg_vbus: regulator@0 {
                                compatible = "regulator-fixed";
                                 reg = <0>;
                                 regulator-name = "usb_otg_vbus";
                                 regulator-min-microvolt = <5000000>;
                                 regulator-max-microvolt = <5000000>;
                                 gpio = <&gpio4 15 0>;
                 };

But as Mark [1] suggested not to use simple bus. Which one is more 
appropriate ?

[1] http://www.spinics.net/lists/linux-usb/msg101477.html

>>> +		compatible = "regulator-fixed";
>>> +		regulator-name = "usb_otg_vbus";
>>> +		regulator-min-microvolt = <5000000>;
>>> +		regulator-max-microvolt = <5000000>;
>>> +		gpio = <&gpio4 15 0>;
>>> +	};
>>>   };

[-- Attachment #2: Type: text/html, Size: 4112 bytes --]