From: Paolo Bonzini <pbonzini@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: imammedo@redhat.com, lersek@redhat.com,
Wanlong Gao <gaowanlong@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH v18 11/14] qapi: make string input visitor parse int list
Date: Wed, 19 Feb 2014 09:42:56 +0100 [thread overview]
Message-ID: <53046E90.2020705@redhat.com> (raw)
In-Reply-To: <20140219081727.GB11157@G08FNSTD100614.fnst.cn.fujitsu.com>
Il 19/02/2014 09:17, Hu Tao ha scritto:
> Two problems:
>
> 1. the code is mostly copied from OptsVisitor. maybe we can share the
> code?
I think it's not a huge problem. Maybe OptsVisitor could be made to use
a StringInputVisitor internally.
> 2. int list is not implemented in string outout visitor. but there is
> currently no user of it. Should we implement it or not?
Yes, please. We probably will add sooner or later a qom-get/qom-set
pair of HMP commands and these will use the string output visitor.
Paolo
next prev parent reply other threads:[~2014-02-19 8:43 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 7:53 [Qemu-devel] [PATCH v18 00/14] Add support for binding guest numa nodes to host numa nodes Hu Tao
2014-02-19 7:53 ` [Qemu-devel] [PATCH v18 01/14] NUMA: move numa related code to new file numa.c Hu Tao
2014-02-19 7:53 ` [Qemu-devel] [PATCH v18 02/14] NUMA: check if the total numa memory size is equal to ram_size Hu Tao
2014-02-25 13:38 ` Eric Blake
2014-02-19 7:53 ` [Qemu-devel] [PATCH v18 03/14] NUMA: Add numa_info structure to contain numa nodes info Hu Tao
2014-02-19 9:26 ` Igor Mammedov
2014-02-21 2:54 ` hu tao
2014-02-19 7:53 ` [Qemu-devel] [PATCH v18 04/14] NUMA: convert -numa option to use OptsVisitor Hu Tao
2014-02-19 7:53 ` [Qemu-devel] [PATCH v18 05/14] NUMA: expand MAX_NODES from 64 to 128 Hu Tao
2014-02-19 7:53 ` [Qemu-devel] [PATCH v18 06/14] qapi: add SIZE type parser to string_input_visitor Hu Tao
2014-02-19 9:54 ` Igor Mammedov
2014-02-19 7:53 ` [Qemu-devel] [PATCH v18 07/14] add memdev backend infrastructure Hu Tao
2014-02-19 9:15 ` Igor Mammedov
2014-02-19 7:53 ` [Qemu-devel] [PATCH v18 08/14] pc: pass QEMUMachineInitArgs to pc_memory_init Hu Tao
2014-02-19 7:54 ` [Qemu-devel] [PATCH v18 09/14] numa: introduce memory_region_allocate_system_memory Hu Tao
2014-02-19 7:54 ` [Qemu-devel] [PATCH v18 10/14] numa: add -numa node, memdev= option Hu Tao
2014-02-19 9:50 ` Igor Mammedov
2014-02-19 11:53 ` Paolo Bonzini
2014-03-04 0:10 ` Eric Blake
2014-03-04 2:20 ` Hu Tao
2014-02-19 7:54 ` [Qemu-devel] [PATCH v18 11/14] qapi: make string input visitor parse int list Hu Tao
2014-02-19 8:17 ` Hu Tao
2014-02-19 8:42 ` Paolo Bonzini [this message]
2014-02-19 7:54 ` [Qemu-devel] [PATCH v18 12/14] qapi: add HostMemPolicy enum type Hu Tao
2014-02-19 9:08 ` Paolo Bonzini
2014-02-19 11:23 ` Igor Mammedov
2014-02-19 7:54 ` [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields Hu Tao
2014-02-19 9:03 ` Paolo Bonzini
2014-02-19 9:36 ` Igor Mammedov
2014-02-25 10:20 ` Hu Tao
2014-02-25 14:15 ` Paolo Bonzini
2014-02-26 5:00 ` Hu Tao
2014-02-26 8:47 ` Igor Mammedov
2014-02-26 8:59 ` Hu Tao
2014-02-26 12:19 ` Igor Mammedov
2014-02-26 11:22 ` Paolo Bonzini
2014-02-26 5:57 ` Hu Tao
2014-02-26 9:05 ` Paolo Bonzini
2014-02-26 9:10 ` Igor Mammedov
2014-02-26 10:33 ` Paolo Bonzini
2014-02-26 12:31 ` Igor Mammedov
2014-02-26 12:45 ` Paolo Bonzini
2014-02-26 12:58 ` Marcelo Tosatti
2014-02-26 13:14 ` Paolo Bonzini
2014-02-26 13:43 ` Igor Mammedov
2014-02-26 13:47 ` Paolo Bonzini
2014-02-26 14:25 ` Igor Mammedov
2014-02-26 14:39 ` Paolo Bonzini
2014-02-25 10:09 ` Hu Tao
2014-03-03 3:24 ` Hu Tao
2014-02-19 7:54 ` [Qemu-devel] [PATCH v18 14/14] amp: add query-memdev Hu Tao
2014-02-19 8:14 ` Hu Tao
2014-02-19 9:07 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53046E90.2020705@redhat.com \
--to=pbonzini@redhat.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=hutao@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.