From: Ian Abbott <abbotti@mev.co.uk>
To: Chase Southwood <chase.southwood@yahoo.com>, gregkh@linuxfoundation.org
Cc: hsweeten@visionengravers.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] Staging: comedi: addi-data: replace printk() with dev_err() in hwdrv_apci1564.c
Date: Wed, 19 Feb 2014 11:06:38 +0000 [thread overview]
Message-ID: <5304903E.7070002@mev.co.uk> (raw)
In-Reply-To: <1392795474-8713-1-git-send-email-chase.southwood@yahoo.com>
On 2014-02-19 07:37, Chase Southwood wrote:
> There were a small handful of printk() calls in hwdrv_apci1564.c. It is
> generally better to use dev_err() for error messages instead, so I
> switched all the printk() calls out, as well as cleaned up the error
> strings.
>
> Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2014-02-19 11:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 7:36 [PATCH 1/4] Staging: comedi: addi-data: cleanup comments in hwdrv_apci1564.c Chase Southwood
2014-02-19 7:37 ` [PATCH 2/4] Staging: comedi: addi-data: cleanup brace usage " Chase Southwood
2014-02-19 11:06 ` Ian Abbott
2014-02-19 7:37 ` [PATCH 3/4] Staging: comedi: addi-data: replace printk() with dev_err() " Chase Southwood
2014-02-19 11:06 ` Ian Abbott [this message]
2014-02-19 7:38 ` [PATCH 4/4] Staging: comedi: addi-data: don't initialize a static variable to 0 Chase Southwood
2014-02-19 11:07 ` Ian Abbott
2014-02-19 8:08 ` [PATCH 1/4] Staging: comedi: addi-data: cleanup comments in hwdrv_apci1564.c Dan Carpenter
2014-02-19 11:05 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5304903E.7070002@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=chase.southwood@yahoo.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.