From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: patches@linaro.org, tim@xen.org, stefano.stabellini@citrix.com,
Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xenproject.org,
Xiantao Zhang <xiantao.zhang@intel.com>
Subject: Re: [RFC for-4.5 08/12] xen/passthrough: iommu: Split generic IOMMU code
Date: Wed, 19 Feb 2014 16:23:22 +0000 [thread overview]
Message-ID: <5304DA7A.2040500@linaro.org> (raw)
In-Reply-To: <1392813550.29739.46.camel@kazak.uk.xensource.com>
Hi Ian,
On 02/19/2014 12:39 PM, Ian Campbell wrote:
> On Fri, 2014-02-07 at 17:43 +0000, Julien Grall wrote:
>> The generic IOMMU framework code (xen/drivers/passthrough/iommu.c) contains
>> functions specific to x86 and PCI.
>>
>> Split the framework in 3 distincts files:
>> - iommu.c: contains generic functions shared between x86 and ARM
>> (when it will be supported)
>> - iommu_pci.c: contains specific functions for PCI passthrough
>> - iommu_x86.c: contains specific functions for x86
>>
>> iommu_pci.c will be only compiled when PCI is supported by the architecture
>> (eg. HAS_PCI is defined).
>>
>> This patch is mostly code movement in new files.
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>> Cc: Xiantao Zhang <xiantao.zhang@intel.com>
>> Cc: Jan Beulich <jbeulich@suse.com>
>> ---
>> xen/drivers/passthrough/Makefile | 6 +-
>> xen/drivers/passthrough/iommu.c | 473 +----------------------------------
>> xen/drivers/passthrough/iommu_pci.c | 468 ++++++++++++++++++++++++++++++++++
>> xen/drivers/passthrough/iommu_x86.c | 65 +++++
>> xen/drivers/passthrough/vtd/iommu.c | 42 ++--
>> xen/include/asm-x86/iommu.h | 46 ++++
>> xen/include/xen/hvm/iommu.h | 1 +
>> xen/include/xen/iommu.h | 42 ++--
>> 8 files changed, 625 insertions(+), 518 deletions(-)
>> create mode 100644 xen/drivers/passthrough/iommu_pci.c
>> create mode 100644 xen/drivers/passthrough/iommu_x86.c
>> create mode 100644 xen/include/asm-x86/iommu.h
>>
>> diff --git a/xen/drivers/passthrough/Makefile b/xen/drivers/passthrough/Makefile
>> index 7c40fa5..51e0a0d 100644
>> --- a/xen/drivers/passthrough/Makefile
>> +++ b/xen/drivers/passthrough/Makefile
>> @@ -3,5 +3,7 @@ subdir-$(x86) += amd
>> subdir-$(x86_64) += x86
>>
>> obj-y += iommu.o
>> -obj-y += io.o
>> -obj-y += pci.o
>> +obj-$(x86) += iommu_x86.o
>> +obj-$(HAS_PCI) += iommu_pci.o
>> +obj-$(x86) += io.o
>
> io.[co] not mentioned in the description?
Right, I will udpate the commit message.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2014-02-19 16:23 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 17:42 [RFC for-4.5 00/12] IOMMU support for ARM Julien Grall
2014-02-07 17:43 ` [RFC for-4.5 01/12] xen/common: grant-table: only call IOMMU if paging mode translate is disabled Julien Grall
2014-02-10 8:02 ` Jan Beulich
2014-02-19 12:25 ` Ian Campbell
2014-02-07 17:43 ` [RFC for-4.5 02/12] xen/passthrough: vtd: Don't export iommu_domain_teardown Julien Grall
2014-02-19 12:26 ` Ian Campbell
2014-02-07 17:43 ` [RFC for-4.5 03/12] xen/passthrough: vtd: Don't export iommu_set_pgd Julien Grall
2014-02-10 8:04 ` Jan Beulich
2014-02-10 8:07 ` Zhang, Xiantao
2014-02-19 12:27 ` Ian Campbell
2014-02-07 17:43 ` [RFC for-4.5 04/12] xen/dts: Add dt_property_read_bool Julien Grall
2014-02-19 12:28 ` Ian Campbell
2014-02-19 14:57 ` Julien Grall
2014-02-07 17:43 ` [RFC for-4.5 05/12] xen/dts: Add dt_parse_phandle_with_args and dt_parse_phandle Julien Grall
2014-02-19 12:34 ` Ian Campbell
2014-02-19 16:17 ` Julien Grall
2014-02-19 16:26 ` Ian Campbell
2014-02-19 16:52 ` Julien Grall
2014-02-19 16:57 ` Ian Campbell
2014-02-07 17:43 ` [RFC for-4.5 06/12] xen/passthrough: rework dom0_pvh_reqs to use it also on ARM Julien Grall
2014-02-10 8:07 ` Jan Beulich
2014-02-10 11:42 ` Julien Grall
2014-02-10 16:10 ` Julien Grall
2014-02-10 16:35 ` Jan Beulich
2014-02-10 17:42 ` Julien Grall
2014-02-11 7:47 ` Jan Beulich
2014-02-07 17:43 ` [RFC for-4.5 07/12] xen/passthrough: iommu: Don't need to map dom0 page when the PT is shared Julien Grall
2014-02-10 8:11 ` Jan Beulich
2014-02-19 12:37 ` Ian Campbell
2014-02-07 17:43 ` [RFC for-4.5 08/12] xen/passthrough: iommu: Split generic IOMMU code Julien Grall
2014-02-10 8:22 ` Jan Beulich
2014-02-10 11:52 ` Julien Grall
2014-02-19 12:39 ` Ian Campbell
2014-02-19 16:23 ` Julien Grall [this message]
2014-02-07 17:43 ` [RFC for-4.5 09/12] xen/passthrough: iommu: Introduce arch specific code Julien Grall
2014-02-19 12:40 ` Ian Campbell
2014-02-19 16:25 ` Julien Grall
2014-02-07 17:43 ` [RFC for-4.5 10/12] xen/passthrough: Introduce IOMMU ARM architure Julien Grall
2014-02-19 12:49 ` Ian Campbell
2014-02-19 16:50 ` Julien Grall
2014-02-07 17:43 ` [RFC for-4.5 11/12] MAINTAINERS: Add drivers/passthrough/arm Julien Grall
2014-02-19 12:49 ` Ian Campbell
2014-02-07 17:43 ` [RFC for-4.5 12/12] drivers/passthrough: arm: Add support for SMMU drivers Julien Grall
2014-02-19 14:15 ` Ian Campbell
2014-02-19 17:21 ` Julien Grall
2014-02-19 17:27 ` Ian Campbell
2014-02-19 17:31 ` Julien Grall
2014-02-20 8:11 ` Jan Beulich
2014-02-20 11:05 ` Julien Grall
2014-02-19 17:23 ` Julien Grall
2014-02-07 17:51 ` [RFC for-4.5 00/12] IOMMU support for ARM Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5304DA7A.2040500@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=patches@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.