Re: [PATCH] infiniband, ocrdma, Fix compiler warning

[Prarit Bhargava <prarit-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On 02/19/2014 11:54 AM, Yann Droneaud wrote:
> Le mercredi 19 février 2014 à 17:47 +0100, Yann Droneaud a écrit :
>> Le mercredi 19 février 2014 à 09:55 -0500, Prarit Bhargava a écrit :
>>> drivers/infiniband/hw/ocrdma/ocrdma_verbs.c: In function ‘_ocrdma_modify_qp’:
>>> drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:1299:31: error: ‘old_qps’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>>>   status = ocrdma_mbx_modify_qp(dev, qp, attr, attr_mask, old_qps);
>>>
>>> ocrdma_mbx_modify_qp() (and subsequent calls) doesn't appear to use old_qps
>>> so it doesn't need to be passed on.  Removing the variable results in the
>>> warning going away.
>>>
>>
>> Nice to see this warning removed.
>>
>>> Signed-off-by: Prarit Bhargava <prarit-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>>>
>>
>> You should move the signed of after the Cc's.
>>
>>> Cc: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>>> Cc: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>>> Cc: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>> Cc: Naresh Gottumukkala <bgottumukkala-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org>
>>> Cc: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>> Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>> ^^^
>> There's a missing Cc: tag

Oops.  I'll add him to v2.

>>
>>> Cc: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>> Cc: "Gottumukkala, Naresh" <B.A.L.NRaju.Gottumukkala-iH1Dq9VlAzfQT0dZR+AlfA@public.gmane.org>
>>
> 
> Additionnaly some addresses seems to be invalid:
> 
> <B.A.L.NRaju.Gottumukkala-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org>: host
> emulex.com.mail5.psmtp.com[64.18.5.10] said: 550 No such user - psmtp
> (in reply to RCPT TO command)
> 
> <bgottumukkala-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org>: host emulex.com.mail5.psmtp.com[64.18.5.10]
> said: 550 No such user - psmtp (in reply to RCPT TO command)

Yep, but those are spit out by get_maintainer.pl before I send the patch.
There's no way to know that they are dead email addresses until the mail is sent
:/.  Trimming them now...

P.

> 
> Regards.
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html