From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGBny-0006wU-OI for qemu-devel@nongnu.org; Wed, 19 Feb 2014 13:23:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGBns-0003mc-QB for qemu-devel@nongnu.org; Wed, 19 Feb 2014 13:23:34 -0500 Received: from cantor2.suse.de ([195.135.220.15]:54895 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGBns-0003mV-JR for qemu-devel@nongnu.org; Wed, 19 Feb 2014 13:23:28 -0500 Message-ID: <5304F69C.8070206@suse.de> Date: Wed, 19 Feb 2014 19:23:24 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1392821445-4587-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1392821445-4587-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 0/3] qtest: avoid pidfile and QEMU process leaks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Peter Maydell , Anthony Liguori Am 19.02.2014 15:50, schrieb Stefan Hajnoczi: > Reviewed by Paolo and Markus. Here is the pull request. >=20 > v2: > * Don't call qtest_end() from SIGABRT handler to avoid reentrancy [Pao= lo] > * Use sigemptyset() to avoid assumption about signal mask [Markus] > * if (fd !=3D -1) close(fd) is no longer necessary [Markus] >=20 > This series prevents the following qtest issues: >=20 > 1. Leaking the pidfile if QEMU startup fails, as discovered by Andreas = F=C3=A4rber. > 2. Leaking the QEMU process when a test case aborts. >=20 > Applying this series should make buildbots and manual "make check" user= s have a > more pleasant and less leaky experience :). >=20 > The following changes since commit 46eef33b89e936ca793e13c4aeea1414e97e= 8dbb: >=20 > Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44:00 +0000) >=20 > are available in the git repository at: >=20 > git://github.com/stefanha/qemu.git tags/qtest-monitor-process-pull-re= quest >=20 > for you to fetch changes up to b15d422a23a3e4cf1b4195af209211eccdb88d51= : >=20 > qtest: kill QEMU process on g_assert() failure (2014-02-19 15:45:51 += 0100) >=20 > ---------------------------------------------------------------- > qtest resource cleanup pull request >=20 > ---------------------------------------------------------------- > Stefan Hajnoczi (3): > qtest: drop unused child_pid field > qtest: make QEMU our direct child process > qtest: kill QEMU process on g_assert() failure >=20 > tests/libqtest.c | 59 +++++++++++++++++++++++++-----------------------= -------- > 1 file changed, 26 insertions(+), 33 deletions(-) Ack, my pending pull touches qtest.c rather than libqtest.c (hope you remembered to check!) and changes look OK, didn't test yet though. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg