From: Zoltan Kiss <zoltan.kiss@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: <wei.liu2@citrix.com>, <xen-devel@lists.xenproject.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<jonathan.davies@citrix.com>
Subject: Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions
Date: Wed, 19 Feb 2014 19:19:31 +0000 [thread overview]
Message-ID: <530503C3.4050307@citrix.com> (raw)
In-Reply-To: <1392744286.23084.52.camel@kazak.uk.xensource.com>
On 18/02/14 17:24, Ian Campbell wrote:
> On Mon, 2014-01-20 at 21:24 +0000, Zoltan Kiss wrote:
>>
>> + spinlock_t dealloc_lock;
>> + spinlock_t response_lock;
>
> Please add comments to both of these describing what bits of the
> datastructure they are locking.
>
> You might find it is clearer to group the locks and the things they
> protect together rather than grouping the locks together.
Ok, I'll give more description here. The response_lock is actually quite
relevant to be here, but indeed that's not obvious, I'll explain that as
well.
Zoli
next prev parent reply other threads:[~2014-02-19 19:19 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 21:24 [PATCH net-next v5 0/9] xen-netback: TX grant mapping with SKBTX_DEV_ZEROCOPY instead of copy Zoltan Kiss
2014-01-20 21:24 ` [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions Zoltan Kiss
2014-02-18 17:06 ` Ian Campbell
2014-02-18 17:06 ` Ian Campbell
2014-02-18 20:36 ` Zoltan Kiss
2014-02-19 10:05 ` Ian Campbell
2014-02-19 10:05 ` Ian Campbell
2014-02-19 19:54 ` Zoltan Kiss
2014-02-19 19:54 ` Zoltan Kiss
2014-02-20 9:33 ` Ian Campbell
2014-02-21 1:19 ` Zoltan Kiss
2014-02-21 1:19 ` Zoltan Kiss
2014-02-24 11:13 ` Ian Campbell
2014-02-24 11:13 ` Ian Campbell
2014-02-20 9:33 ` Ian Campbell
2014-02-20 10:13 ` Wei Liu
2014-02-20 10:13 ` Wei Liu
2014-02-18 20:36 ` Zoltan Kiss
2014-02-18 17:24 ` Ian Campbell
2014-02-18 17:24 ` Ian Campbell
2014-02-19 19:19 ` Zoltan Kiss
2014-02-19 19:19 ` Zoltan Kiss [this message]
2014-01-20 21:24 ` Zoltan Kiss
2014-01-20 21:24 ` [PATCH net-next v5 2/9] xen-netback: Change TX path from grant copy to mapping Zoltan Kiss
2014-01-20 21:24 ` Zoltan Kiss
2014-02-18 17:40 ` Ian Campbell
2014-02-18 18:46 ` David Vrabel
2014-02-18 18:46 ` [Xen-devel] " David Vrabel
2014-02-19 9:54 ` Ian Campbell
2014-02-19 9:54 ` [Xen-devel] " Ian Campbell
2014-02-19 12:27 ` David Vrabel
2014-02-19 12:27 ` David Vrabel
2014-02-22 22:33 ` Zoltan Kiss
2014-02-24 16:56 ` Zoltan Kiss
2014-02-24 16:56 ` Zoltan Kiss
2014-02-22 22:33 ` Zoltan Kiss
2014-02-18 17:40 ` Ian Campbell
2014-01-20 21:24 ` [PATCH net-next v5 3/9] xen-netback: Remove old TX grant copy definitons and fix indentations Zoltan Kiss
2014-01-20 21:24 ` Zoltan Kiss
2014-01-20 21:24 ` [PATCH net-next v5 4/9] xen-netback: Change RX path for mapped SKB fragments Zoltan Kiss
2014-01-20 21:24 ` Zoltan Kiss
2014-02-18 17:45 ` Ian Campbell
2014-02-22 23:18 ` Zoltan Kiss
2014-02-24 13:49 ` Zoltan Kiss
2014-02-24 15:08 ` Zoltan Kiss
2014-02-27 12:43 ` Wei Liu
2014-02-27 15:49 ` Zoltan Kiss
2014-02-27 15:49 ` Zoltan Kiss
2014-02-27 16:01 ` Wei Liu
2014-02-27 16:01 ` Wei Liu
2014-02-27 12:43 ` Wei Liu
2014-02-24 15:08 ` Zoltan Kiss
2014-02-24 13:49 ` Zoltan Kiss
2014-02-22 23:18 ` Zoltan Kiss
2014-02-18 17:45 ` Ian Campbell
2014-01-20 21:24 ` [PATCH net-next v5 5/9] xen-netback: Add stat counters for zerocopy Zoltan Kiss
2014-01-20 21:24 ` Zoltan Kiss
2014-01-20 21:24 ` [PATCH net-next v5 6/9] xen-netback: Handle guests with too many frags Zoltan Kiss
2014-01-20 21:24 ` Zoltan Kiss
2014-01-20 21:24 ` [PATCH net-next v5 7/9] xen-netback: Add stat counters for frag_list skbs Zoltan Kiss
2014-01-20 21:24 ` Zoltan Kiss
2014-01-20 21:24 ` [PATCH net-next v5 8/9] xen-netback: Timeout packets in RX path Zoltan Kiss
2014-01-20 22:03 ` Wei Liu
2014-01-20 22:12 ` Wei Liu
2014-01-20 22:12 ` Wei Liu
2014-01-21 0:24 ` Zoltan Kiss
2014-01-21 0:24 ` Zoltan Kiss
2014-01-20 22:03 ` Wei Liu
2014-01-20 21:24 ` Zoltan Kiss
2014-01-20 21:24 ` [PATCH net-next v5 9/9] xen-netback: Aggregate TX unmap operations Zoltan Kiss
2014-01-20 21:24 ` Zoltan Kiss
2014-01-23 1:50 ` [PATCH net-next v5 0/9] xen-netback: TX grant mapping with SKBTX_DEV_ZEROCOPY instead of copy David Miller
2014-01-23 1:50 ` David Miller
2014-01-23 13:13 ` Zoltan Kiss
2014-01-23 13:13 ` Zoltan Kiss
2014-01-23 21:39 ` David Miller
2014-01-23 21:49 ` Zoltan Kiss
2014-01-23 21:49 ` Zoltan Kiss
2014-01-23 21:39 ` David Miller
2014-02-19 9:50 ` Ian Campbell
2014-02-24 15:31 ` Zoltan Kiss
2014-02-24 15:31 ` Zoltan Kiss
2014-02-19 9:50 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530503C3.4050307@citrix.com \
--to=zoltan.kiss@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=jonathan.davies@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.