From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37924)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1WGEe9-0001fk-Nj
	for qemu-devel@nongnu.org; Wed, 19 Feb 2014 16:25:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1WGEe2-0002bD-70
	for qemu-devel@nongnu.org; Wed, 19 Feb 2014 16:25:37 -0500
Received: from s16892447.onlinehome-server.info ([82.165.15.123]:34377)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1WGEe1-0002b4-VH
	for qemu-devel@nongnu.org; Wed, 19 Feb 2014 16:25:30 -0500
Message-ID: <530520CE.4060805@ilande.co.uk>
Date: Wed, 19 Feb 2014 21:23:26 +0000
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
MIME-Version: 1.0
References: <1391877522-17254-1-git-send-email-mark.cave-ayland@ilande.co.uk>
	<1391877522-17254-3-git-send-email-mark.cave-ayland@ilande.co.uk>
	<52F79F7B.30000@suse.de> <530200F1.7050704@ilande.co.uk>
In-Reply-To: <530200F1.7050704@ilande.co.uk>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCHv2 2/2] sun4m: Add Sun CG3 framebuffer
 initialisation function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Bob Breuer <breuerr@mc.net>, Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Alon Levy <alevy@redhat.com>, Artyom Tarasenko <atar4qemu@gmail.com>

On 17/02/14 12:30, Mark Cave-Ayland wrote:

> On 09/02/14 15:32, Andreas Färber wrote:
>
>> IIUC SUNW,cgthree is an optional device, so it's not covered by my
>> qom-test. Please follow-up with a tests/cg3-test.c so that it gets
>> covered. Compare my recent PCI NIC series for how such a stub could look
>> like, in particular vmxnet3-test.c since this will be sparc-only.
>
> Okay - should this be a totally separate patch or appended to the end of
> this patchset?

So I tried this, and if I launch with -device cgthree then I get an 
error about the device not being pluggable (which I'm guessing is 
because the device is attached to sysbus).

Some further poking shows that several other of the -vga devices appear 
to be marked as non-pluggable too, so I'm not sure this could work with 
QOM tests based upon the current implementation.


ATB,

Mark.