From: "Yan, Zheng" <zheng.z.yan@intel.com>
To: Stephane Eranian <eranian@google.com>, linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, mingo@elte.hu, ak@linux.intel.com
Subject: Re: [PATCH] perf/x86/uncore: Fix IVT/SNB-EP uncore CBOX NID filter table
Date: Thu, 20 Feb 2014 14:20:13 +0800 [thread overview]
Message-ID: <53059E9D.1030109@intel.com> (raw)
In-Reply-To: <20140219131018.GA24475@quad>
On 02/19/2014 09:10 PM, Stephane Eranian wrote:
>
> This patch updates the CBOX PMU filters mapping tables for SNB-EP
> and IVT (model 45 and 62 respectively).
>
> The NID umask always comes in addition to another umask.
> When set, the NID filter is applied.
Do you means the NID always applies for LLC_LOOKUP no matter what umask is.
If yes, I think it's better to define filter as SNBEP_CBO_EVENT_EXTRA_REG(0x34, 0xff, 0x6)
Regards
Yan, Zheng
>
> The current mapping tables were missing some code/umask
> combinations to account for the NID umask. This patch
> fixes that.
>
> Signed-off-by: Stephane Eranian <eranian@google.com>
>
> diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> @@ -501,8 +501,11 @@ static struct extra_reg snbep_uncore_cbox_extra_regs[] = {
> SNBEP_CBO_EVENT_EXTRA_REG(SNBEP_CBO_PMON_CTL_TID_EN,
> SNBEP_CBO_PMON_CTL_TID_EN, 0x1),
> SNBEP_CBO_EVENT_EXTRA_REG(0x0334, 0xffff, 0x4),
> + SNBEP_CBO_EVENT_EXTRA_REG(0x4334, 0xffff, 0x6),
> SNBEP_CBO_EVENT_EXTRA_REG(0x0534, 0xffff, 0x4),
> + SNBEP_CBO_EVENT_EXTRA_REG(0x4534, 0xffff, 0x6),
> SNBEP_CBO_EVENT_EXTRA_REG(0x0934, 0xffff, 0x4),
> + SNBEP_CBO_EVENT_EXTRA_REG(0x4934, 0xffff, 0x6),
> SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0x6),
> SNBEP_CBO_EVENT_EXTRA_REG(0x0135, 0xffff, 0x8),
> SNBEP_CBO_EVENT_EXTRA_REG(0x0335, 0xffff, 0x8),
> @@ -1178,10 +1181,15 @@ static struct extra_reg ivt_uncore_cbox_extra_regs[] = {
> SNBEP_CBO_EVENT_EXTRA_REG(SNBEP_CBO_PMON_CTL_TID_EN,
> SNBEP_CBO_PMON_CTL_TID_EN, 0x1),
> SNBEP_CBO_EVENT_EXTRA_REG(0x1031, 0x10ff, 0x2),
> + SNBEP_CBO_EVENT_EXTRA_REG(0x1134, 0xffff, 0x4),
> + SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0xc),
> + SNBEP_CBO_EVENT_EXTRA_REG(0x5134, 0xffff, 0xc),
> SNBEP_CBO_EVENT_EXTRA_REG(0x0334, 0xffff, 0x4),
> + SNBEP_CBO_EVENT_EXTRA_REG(0x4334, 0xffff, 0xc),
> SNBEP_CBO_EVENT_EXTRA_REG(0x0534, 0xffff, 0x4),
> + SNBEP_CBO_EVENT_EXTRA_REG(0x4534, 0xffff, 0xc),
> SNBEP_CBO_EVENT_EXTRA_REG(0x0934, 0xffff, 0x4),
> - SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0xc),
> + SNBEP_CBO_EVENT_EXTRA_REG(0x4934, 0xffff, 0xc),
> SNBEP_CBO_EVENT_EXTRA_REG(0x0135, 0xffff, 0x10),
> SNBEP_CBO_EVENT_EXTRA_REG(0x0335, 0xffff, 0x10),
> SNBEP_CBO_EVENT_EXTRA_REG(0x2135, 0xffff, 0x10),
>
next prev parent reply other threads:[~2014-02-20 6:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 13:10 [PATCH] perf/x86/uncore: Fix IVT/SNB-EP uncore CBOX NID filter table Stephane Eranian
2014-02-20 6:20 ` Yan, Zheng [this message]
2014-02-20 8:56 ` Stephane Eranian
2014-02-20 9:00 ` Yan, Zheng
2014-02-21 21:14 ` [tip:perf/urgent] perf/x86/uncore: Fix IVT/ SNB-EP " tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53059E9D.1030109@intel.com \
--to=zheng.z.yan@intel.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.