From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH RFC] User namespaces: general cleanups Date: Tue, 14 Oct 2008 00:10:56 +0100 Message-ID: <5306.1223939456@redhat.com> References: <20081013214108.GA4701@us.ibm.com> <20081010011917.GA8046@us.ibm.com> <30854.1223633214@redhat.com> <20081013160144.GA10359@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20081013214108.GA4701-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Serge E. Hallyn" Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Linux Containers , "Eric W. Biederman" List-Id: containers.vger.kernel.org Serge E. Hallyn wrote: > With the following patch applied to the base next-creds-subsys branch, > you can track that if you login as root, then do 'su hallyn', where > hallyn is uid 500, then uid 500 gets allocated twice. So free is never > called on it. Which following patch? Actually, I've suspected that the user_struct accounting is not quite right for a while. Even before I did my creds stuff, I'd occasionally multiple per-UID keyrings cropping up with the same ID - indicating multiple user_structs for the same UID. David